From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 0EAC23858412; Tue, 27 Jun 2023 17:21:40 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0EAC23858412
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1687886500;
	bh=iR3CSoT6lIsCYe7boDjAYxaJPqETF/PuL/eZgNFSpWo=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=TjmHt4N7N8R/uokxRFaMjwsB/0/HX3zc5hYj2yufI+lM6L4WmEgkz4V4WWF9V60Yn
	 iQex1lU8NGWsnbJchOHvPndJg26F9V1XSwjjAK8bLF1hUejC/Mo9ZI2SPpfk6GZZvG
	 1vhMRQuTLliAA3lASXjxL2Kd9xy3mhN4P7zOURTo=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/103979] asm goto is not considered volatile with
 output operands
Date: Tue, 27 Jun 2023 17:21:39 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 11.2.0
X-Bugzilla-Keywords: ice-on-valid-code, inline-asm, patch, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-103979-4-RPezIwRFa2@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-103979-4@http.gcc.gnu.org/bugzilla/>
References: <bug-103979-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D103979

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:ee3bb7cb5d2ecfc64adcfd61afb390e72cc08661

commit r12-9732-gee3bb7cb5d2ecfc64adcfd61afb390e72cc08661
Author: Andrew Pinski <apinski@marvell.com>
Date:   Mon Jun 26 17:14:06 2023 -0700

    Mark asm goto with outputs as volatile

    The manual references asm goto as being implicitly volatile already
    and that was done when asm goto could not have outputs. When outputs
    were added to `asm goto`, only asm goto without outputs were still being
    marked as volatile. Now some parts of GCC decide, removing the `asm got=
o`
    is ok if the output is not used, though not updating the CFG (this happ=
ens
    on both the RTL level and the gimple level). Since the biggest user of =
`asm
goto`
    is the Linux kernel and they expect them to be volatile (they use them =
to
    copy to/from userspace), we should just mark the inline-asm as volatile.

    OK? Bootstrapped and tested on x86_64-linux-gnu.

            PR middle-end/110420
            PR middle-end/103979
            PR middle-end/98619

    gcc/ChangeLog:

            * gimplify.cc (gimplify_asm_expr): Mark asm with labels as
volatile.

    gcc/testsuite/ChangeLog:

            * gcc.c-torture/compile/asmgoto-6.c: New test.

    (cherry picked from commit 478840a2ca491fbff44371caee4983d1e7b7b7cf)=