public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/103979] asm goto is not considered volatile with output operands Date: Tue, 27 Jun 2023 16:46:21 +0000 [thread overview] Message-ID: <bug-103979-4-gf0CWbwPf0@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103979-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103979 --- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-13 branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>: https://gcc.gnu.org/g:81fa6dfe1691e93664ef3b4fa66c1e057acea281 commit r13-7484-g81fa6dfe1691e93664ef3b4fa66c1e057acea281 Author: Andrew Pinski <apinski@marvell.com> Date: Mon Jun 26 17:14:06 2023 -0700 Mark asm goto with outputs as volatile The manual references asm goto as being implicitly volatile already and that was done when asm goto could not have outputs. When outputs were added to `asm goto`, only asm goto without outputs were still being marked as volatile. Now some parts of GCC decide, removing the `asm goto` is ok if the output is not used, though not updating the CFG (this happens on both the RTL level and the gimple level). Since the biggest user of `asm goto` is the Linux kernel and they expect them to be volatile (they use them to copy to/from userspace), we should just mark the inline-asm as volatile. OK? Bootstrapped and tested on x86_64-linux-gnu. PR middle-end/110420 PR middle-end/103979 PR middle-end/98619 gcc/ChangeLog: * gimplify.cc (gimplify_asm_expr): Mark asm with labels as volatile. gcc/testsuite/ChangeLog: * gcc.c-torture/compile/asmgoto-6.c: New test. (cherry picked from commit 478840a2ca491fbff44371caee4983d1e7b7b7cf)
next prev parent reply other threads:[~2023-06-27 16:46 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-11 16:29 [Bug c/103979] New: asm goto is not considered volatile gareth.webb+gccbugzilla at outlook dot com 2022-01-11 18:46 ` [Bug rtl-optimization/103979] asm goto is not considered volatile with output operands pinskia at gcc dot gnu.org 2023-01-25 22:17 ` pinskia at gcc dot gnu.org 2023-01-30 18:06 ` jakub at gcc dot gnu.org 2023-01-30 18:18 ` jakub at gcc dot gnu.org 2023-06-26 23:38 ` [Bug middle-end/103979] " pinskia at gcc dot gnu.org 2023-06-26 23:53 ` pinskia at gcc dot gnu.org 2023-06-27 0:10 ` pinskia at gcc dot gnu.org 2023-06-27 3:26 ` pinskia at gcc dot gnu.org 2023-06-27 16:28 ` cvs-commit at gcc dot gnu.org 2023-06-27 16:29 ` pinskia at gcc dot gnu.org 2023-06-27 16:46 ` cvs-commit at gcc dot gnu.org [this message] 2023-06-27 17:21 ` cvs-commit at gcc dot gnu.org 2023-06-27 17:24 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103979-4-gf0CWbwPf0@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).