public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/103989] [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og since r12-1992-g6feb628a706e86eb Date: Thu, 13 Jan 2022 15:01:20 +0000 [thread overview] Message-ID: <bug-103989-4-MNKIP2UOKX@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103989-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103989 --- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:53ead5787921be799593232cfc9931f916b79002 commit r12-6550-g53ead5787921be799593232cfc9931f916b79002 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Jan 13 15:59:47 2022 +0100 inliner: Don't emit copy stmts for empty type parameters [PR103989] The following patch avoids emitting a parameter copy statement when inlining if the parameter has empty type. E.g. the gimplifier does something similar (except that it needs to evaluate side-effects if any, which isn't the case here): /* For empty types only gimplify the left hand side and right hand side as statements and throw away the assignment. Do this after gimplify_modify_expr_rhs so we handle TARGET_EXPRs of addressable types properly. */ if (is_empty_type (TREE_TYPE (*from_p)) && !want_value /* Don't do this for calls that return addressable types, expand_call relies on those having a lhs. */ && !(TREE_ADDRESSABLE (TREE_TYPE (*from_p)) && TREE_CODE (*from_p) == CALL_EXPR)) { gimplify_stmt (from_p, pre_p); gimplify_stmt (to_p, pre_p); *expr_p = NULL_TREE; return GS_ALL_DONE; } Unfortunately, this patch doesn't cure the uninit warnings in that PR, which is caused by ipa inlining happening even at -Og when the post-IPA -Og passes don't expect the need to clean up after ipa inlining, but I think is desirable anyway. 2022-01-13 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/103989 * tree-inline.c (setup_one_parameter): Don't copy parms with empty type.
next prev parent reply other threads:[~2022-01-13 15:01 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-12 12:10 [Bug tree-optimization/103989] New: [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og marc@nieper-wisskirchen.de 2022-01-12 12:16 ` [Bug tree-optimization/103989] [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og since r12-1992-g6feb628a706e86eb marxin at gcc dot gnu.org 2022-01-12 12:54 ` rguenth at gcc dot gnu.org 2022-01-12 17:44 ` jakub at gcc dot gnu.org 2022-01-12 19:11 ` pinskia at gcc dot gnu.org 2022-01-13 11:10 ` jakub at gcc dot gnu.org 2022-01-13 11:39 ` rguenth at gcc dot gnu.org 2022-01-13 11:56 ` Jan Hubicka 2022-01-13 11:56 ` hubicka at kam dot mff.cuni.cz 2022-01-13 12:03 ` Jan Hubicka 2022-01-13 12:03 ` hubicka at kam dot mff.cuni.cz 2022-01-13 12:25 ` rguenth at gcc dot gnu.org 2022-01-13 13:39 ` hubicka at kam dot mff.cuni.cz 2022-01-13 13:44 ` rguenther at suse dot de 2022-01-13 13:55 ` hubicka at kam dot mff.cuni.cz 2022-01-13 13:58 ` rguenth at gcc dot gnu.org 2022-01-13 14:11 ` Jan Hubicka 2022-01-13 14:11 ` hubicka at kam dot mff.cuni.cz 2022-01-13 15:01 ` cvs-commit at gcc dot gnu.org [this message] 2022-01-13 15:05 ` jakub at gcc dot gnu.org 2022-01-13 15:10 ` rguenther at suse dot de 2022-01-18 12:35 ` rguenth at gcc dot gnu.org 2022-01-18 14:43 ` cvs-commit at gcc dot gnu.org 2022-01-18 14:43 ` cvs-commit at gcc dot gnu.org 2022-01-18 14:43 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103989-4-MNKIP2UOKX@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).