public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103989] [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og since r12-1992-g6feb628a706e86eb
Date: Thu, 13 Jan 2022 11:10:01 +0000	[thread overview]
Message-ID: <bug-103989-4-NvPDLjC5sM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103989-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103989

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The reason we warn is that at -Og we don't optimize away the dead code.  In
uninit2 we have:
  MEM[(struct _Optional_payload_base *)&D.34851]._M_engaged = 0;
...
  _27 = MEM[(const struct _Optional_payload_base &)&D.34851]._M_engaged;
  if (_27 != 0)
    goto <bb 3>; [33.00%]
  else
    goto <bb 10>; [67.00%]

  <bb 10> [local count: 719407024]:
  goto <bb 9>; [100.00%]

  <bb 3> [local count: 354334800]:
  MEM[(struct __as_base  &)&b] ={v} {CLOBBER};
  MEM[(struct shared_ptr *)&b] ={v} {CLOBBER};
  MEM[(struct __shared_ptr *)&b] ={v} {CLOBBER};
  _30 = MEM[(const struct __shared_ptr &)&D.34851]._M_ptr;
  MEM[(struct __shared_ptr *)&b]._M_ptr = _30;
  MEM[(struct __shared_count *)&b + 8B] ={v} {CLOBBER};
  _31 = MEM[(const struct __shared_count &)&D.34851 + 8]._M_pi;
  MEM[(struct __shared_count *)&b + 8B]._M_pi = _31;
and we haven't figured out that bb 3 is all dead, because we store into
_M_engaged 0 and bb 3 is done only if _M_engaged is non-zero.
-Og runs fre1, but that is too early, fre1 sees
  MEM[(struct _Optional_payload_base *)&D.34851]._M_engaged = 0;
  D.35431 ={v} {CLOBBER};
  b ={v} {CLOBBER};
  MEM[(struct optional *)&b] ={v} {CLOBBER};
  std::_Optional_base<A, false, false>::_Optional_base (&MEM[(struct optional
*)&b].D.34640, &D.34851.D.34640);
and _Optional_base isn't inlined there.  And -Og doesn't do any FRE or PRE
after inlining, unlike e.g. -O1 which has fre3 very soon after inlining.
-Og doesn't even do forwprop after inlining.

  parent reply	other threads:[~2022-01-13 11:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 12:10 [Bug tree-optimization/103989] New: [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og marc@nieper-wisskirchen.de
2022-01-12 12:16 ` [Bug tree-optimization/103989] [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og since r12-1992-g6feb628a706e86eb marxin at gcc dot gnu.org
2022-01-12 12:54 ` rguenth at gcc dot gnu.org
2022-01-12 17:44 ` jakub at gcc dot gnu.org
2022-01-12 19:11 ` pinskia at gcc dot gnu.org
2022-01-13 11:10 ` jakub at gcc dot gnu.org [this message]
2022-01-13 11:39 ` rguenth at gcc dot gnu.org
2022-01-13 11:56   ` Jan Hubicka
2022-01-13 11:56 ` hubicka at kam dot mff.cuni.cz
2022-01-13 12:03   ` Jan Hubicka
2022-01-13 12:03 ` hubicka at kam dot mff.cuni.cz
2022-01-13 12:25 ` rguenth at gcc dot gnu.org
2022-01-13 13:39 ` hubicka at kam dot mff.cuni.cz
2022-01-13 13:44 ` rguenther at suse dot de
2022-01-13 13:55 ` hubicka at kam dot mff.cuni.cz
2022-01-13 13:58 ` rguenth at gcc dot gnu.org
2022-01-13 14:11   ` Jan Hubicka
2022-01-13 14:11 ` hubicka at kam dot mff.cuni.cz
2022-01-13 15:01 ` cvs-commit at gcc dot gnu.org
2022-01-13 15:05 ` jakub at gcc dot gnu.org
2022-01-13 15:10 ` rguenther at suse dot de
2022-01-18 12:35 ` rguenth at gcc dot gnu.org
2022-01-18 14:43 ` cvs-commit at gcc dot gnu.org
2022-01-18 14:43 ` cvs-commit at gcc dot gnu.org
2022-01-18 14:43 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103989-4-NvPDLjC5sM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).