public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at kam dot mff.cuni.cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103989] [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og since r12-1992-g6feb628a706e86eb
Date: Thu, 13 Jan 2022 13:39:48 +0000	[thread overview]
Message-ID: <bug-103989-4-U4HAw6JiNh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103989-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103989

--- Comment #10 from hubicka at kam dot mff.cuni.cz ---
> And I'm intentionally not doing this because -Og should still remove
> abstraction during early inlining (for functions marked 'inline'), we
> just don't want to spend the extra compile time doing IPA inlining
> or cleaning up after IPA inlining.

Indeed it seemed bit too extreme to disable inlining completely at -Og :)
So you want early inliner to behave normally according to flags
while IPA inliner to skip all calls where either caller or
callee is -Og and callee is not always_inline?
This can be done in can_inline_edge_p. I will make patch for that.

It may be nice to also avoid re-analyzing functions completely to save
some compile time, but that may be bit tricky if we decide to do things
like cross-module always_inline.  I will look into that too, but perhaps
that can wait for next stage1.
> 
> but of course IPA inline size estimates are a bit off since we are not
> going to do any optimization on the inlined body.

We still do late ccp and other things, but indeed inline estimates
anticipate FRE to happen which it doesn't.

Looking into what passes are in the pipeline I also noticed that
we could also probably skip late modref from -Og optimization pipeline.
(I think David added it htere originally since we do pure-const).
I am thinking about retiring pure-const from pure-const discovery next
stage1 since modref should be monotonosly stronger doing that (and
if we add a stripped down mode of modref it should not be more expensive
than pure-const)

  parent reply	other threads:[~2022-01-13 13:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 12:10 [Bug tree-optimization/103989] New: [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og marc@nieper-wisskirchen.de
2022-01-12 12:16 ` [Bug tree-optimization/103989] [12 regression] std::optional and bogus -Wmaybe-unitialized at -Og since r12-1992-g6feb628a706e86eb marxin at gcc dot gnu.org
2022-01-12 12:54 ` rguenth at gcc dot gnu.org
2022-01-12 17:44 ` jakub at gcc dot gnu.org
2022-01-12 19:11 ` pinskia at gcc dot gnu.org
2022-01-13 11:10 ` jakub at gcc dot gnu.org
2022-01-13 11:39 ` rguenth at gcc dot gnu.org
2022-01-13 11:56   ` Jan Hubicka
2022-01-13 11:56 ` hubicka at kam dot mff.cuni.cz
2022-01-13 12:03   ` Jan Hubicka
2022-01-13 12:03 ` hubicka at kam dot mff.cuni.cz
2022-01-13 12:25 ` rguenth at gcc dot gnu.org
2022-01-13 13:39 ` hubicka at kam dot mff.cuni.cz [this message]
2022-01-13 13:44 ` rguenther at suse dot de
2022-01-13 13:55 ` hubicka at kam dot mff.cuni.cz
2022-01-13 13:58 ` rguenth at gcc dot gnu.org
2022-01-13 14:11   ` Jan Hubicka
2022-01-13 14:11 ` hubicka at kam dot mff.cuni.cz
2022-01-13 15:01 ` cvs-commit at gcc dot gnu.org
2022-01-13 15:05 ` jakub at gcc dot gnu.org
2022-01-13 15:10 ` rguenther at suse dot de
2022-01-18 12:35 ` rguenth at gcc dot gnu.org
2022-01-18 14:43 ` cvs-commit at gcc dot gnu.org
2022-01-18 14:43 ` cvs-commit at gcc dot gnu.org
2022-01-18 14:43 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103989-4-U4HAw6JiNh@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).