public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/103991] [12 Regression] Bogus -Wreturn-type with constexpr if and local var with destructor Date: Wed, 12 Jan 2022 16:58:40 +0000 [thread overview] Message-ID: <bug-103991-4-uOEGJW6iv9@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103991-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103991 --- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> --- For consteval if I guess we could do: --- gcc/cp/cp-objcp-common.c.jj 2022-01-11 23:11:22.091294356 +0100 +++ gcc/cp/cp-objcp-common.c 2022-01-12 17:57:18.232202275 +0100 @@ -313,6 +313,13 @@ cxx_block_may_fallthru (const_tree stmt) return false; case IF_STMT: + if (IF_STMT_CONSTEXPR_P (stmt)) + { + if (integer_nonzerop (IF_COND (stmt))) + return block_may_fallthru (THEN_CLAUSE (stmt)); + if (integer_zerop (IF_COND (stmt))) + return block_may_fallthru (ELSE_CLAUSE (stmt)); + } if (block_may_fallthru (THEN_CLAUSE (stmt))) return true; return block_may_fallthru (ELSE_CLAUSE (stmt)); --- gcc/cp/cp-gimplify.c.jj 2022-01-11 23:11:22.090294370 +0100 +++ gcc/cp/cp-gimplify.c 2022-01-12 17:53:57.431036236 +0100 @@ -166,8 +166,13 @@ genericize_if_stmt (tree *stmt_p) can contain unfolded immediate function calls, we have to discard the then_ block regardless of whether else_ has side-effects or not. */ if (IF_STMT_CONSTEVAL_P (stmt)) - stmt = build3 (COND_EXPR, void_type_node, boolean_false_node, - void_node, else_); + { + if (block_may_fallthru (then_)) + stmt = build3 (COND_EXPR, void_type_node, boolean_false_node, + void_node, else_); + else + stmt = else_; + } else stmt = build3 (COND_EXPR, void_type_node, cond, then_, else_); protected_set_expr_location_if_unset (stmt, locus);
next prev parent reply other threads:[~2022-01-12 16:58 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-12 13:56 [Bug c++/103991] New: " sbergman at redhat dot com 2022-01-12 14:03 ` [Bug c++/103991] [12 Regression] " jakub at gcc dot gnu.org 2022-01-12 16:04 ` jakub at gcc dot gnu.org 2022-01-12 16:06 ` jakub at gcc dot gnu.org 2022-01-12 16:33 ` jakub at gcc dot gnu.org 2022-01-12 16:47 ` jakub at gcc dot gnu.org 2022-01-12 16:58 ` jakub at gcc dot gnu.org [this message] 2022-01-12 19:42 ` rguenther at suse dot de 2022-01-12 20:02 ` jakub at gcc dot gnu.org 2022-01-14 11:10 ` cvs-commit at gcc dot gnu.org 2022-01-17 17:48 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103991-4-uOEGJW6iv9@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).