* [Bug target/104005] Regression on arm+sve with -O2 -fPIC
2022-01-13 11:41 [Bug target/104005] New: Regression on arm+sve with -O2 -fPIC gilles.gouaillardet at gmail dot com
@ 2022-01-14 19:17 ` rsandifo at gcc dot gnu.org
2022-01-17 9:02 ` [Bug target/104005] [12 Regression] " rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2022-01-14 19:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104005
rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2022-01-14
Status|UNCONFIRMED |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |rsandifo at gcc dot gnu.org
Ever confirmed|0 |1
CC| |rsandifo at gcc dot gnu.org
--- Comment #1 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Thanks for the report. I'll try to reproduce this next week.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104005] [12 Regression] Regression on arm+sve with -O2 -fPIC
2022-01-13 11:41 [Bug target/104005] New: Regression on arm+sve with -O2 -fPIC gilles.gouaillardet at gmail dot com
2022-01-14 19:17 ` [Bug target/104005] " rsandifo at gcc dot gnu.org
@ 2022-01-17 9:02 ` rguenth at gcc dot gnu.org
2022-01-17 9:07 ` [Bug target/104005] [12 Regression] Regression on aarch64+sve " pinskia at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-01-17 9:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104005
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
Priority|P3 |P1
Summary|Regression on arm+sve with |[12 Regression] Regression
|-O2 -fPIC |on arm+sve with -O2 -fPIC
Keywords| |wrong-code
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104005] [12 Regression] Regression on aarch64+sve with -O2 -fPIC
2022-01-13 11:41 [Bug target/104005] New: Regression on arm+sve with -O2 -fPIC gilles.gouaillardet at gmail dot com
2022-01-14 19:17 ` [Bug target/104005] " rsandifo at gcc dot gnu.org
2022-01-17 9:02 ` [Bug target/104005] [12 Regression] " rguenth at gcc dot gnu.org
@ 2022-01-17 9:07 ` pinskia at gcc dot gnu.org
2022-01-17 9:13 ` [Bug target/104005] [12 Regression] Regression on aarch64+sve with -O2 -fPIC since r12-5204 gilles.gouaillardet at gmail dot com
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-01-17 9:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104005
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
>The attached tarball includes preprocessed source
I think it was too big when you tried to create the bug report (it is known
issue that bugzilla does not report the attachment fails when creating the bug
report). Was the tar ball compressed if not try xz to compress it and attach
that.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104005] [12 Regression] Regression on aarch64+sve with -O2 -fPIC since r12-5204
2022-01-13 11:41 [Bug target/104005] New: Regression on arm+sve with -O2 -fPIC gilles.gouaillardet at gmail dot com
` (2 preceding siblings ...)
2022-01-17 9:07 ` [Bug target/104005] [12 Regression] Regression on aarch64+sve " pinskia at gcc dot gnu.org
@ 2022-01-17 9:13 ` gilles.gouaillardet at gmail dot com
2022-01-17 9:14 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gilles.gouaillardet at gmail dot com @ 2022-01-17 9:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104005
--- Comment #3 from Gilles Gouaillardet <gilles.gouaillardet at gmail dot com> ---
Created attachment 52210
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52210&action=edit
before/after (preprocessed sources + assembly)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104005] [12 Regression] Regression on aarch64+sve with -O2 -fPIC since r12-5204
2022-01-13 11:41 [Bug target/104005] New: Regression on arm+sve with -O2 -fPIC gilles.gouaillardet at gmail dot com
` (3 preceding siblings ...)
2022-01-17 9:13 ` [Bug target/104005] [12 Regression] Regression on aarch64+sve with -O2 -fPIC since r12-5204 gilles.gouaillardet at gmail dot com
@ 2022-01-17 9:14 ` pinskia at gcc dot gnu.org
2022-01-18 12:20 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-01-17 9:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104005
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Gilles Gouaillardet from comment #3)
> Created attachment 52210 [details]
> before/after (preprocessed sources + assembly)
Thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104005] [12 Regression] Regression on aarch64+sve with -O2 -fPIC since r12-5204
2022-01-13 11:41 [Bug target/104005] New: Regression on arm+sve with -O2 -fPIC gilles.gouaillardet at gmail dot com
` (4 preceding siblings ...)
2022-01-17 9:14 ` pinskia at gcc dot gnu.org
@ 2022-01-18 12:20 ` cvs-commit at gcc dot gnu.org
2022-01-18 12:22 ` rsandifo at gcc dot gnu.org
2022-01-19 8:25 ` gilles.gouaillardet at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-01-18 12:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104005
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:
https://gcc.gnu.org/g:38ec23fafb167ddfe840d7bb22b3e943d8a7d29e
commit r12-6669-g38ec23fafb167ddfe840d7bb22b3e943d8a7d29e
Author: Richard Sandiford <richard.sandiford@arm.com>
Date: Tue Jan 18 12:20:00 2022 +0000
aarch64: Fix overly optimistic LDP/STP matching [PR104005]
In g:526e1639aa76b0a8496b0dc3a3ff2c450229544e I'd added support
for finding more consecutive MEMs. However, the check was too
eager, in that it matched MEM_REFs with the same base address
even if that base address was an arbitrary SSA name. This can
give wrong results if a MEM_REF from one loop iteration is
compared with a MEM_REF from another (e.g. after rtl unrolling).
In principle, we could still accept MEM_REFs based on the same
incoming SSA name, but there seems to be no out-of-the-box API
for doing that. Adding a new one at this stage in GCC 12 doesn't
feel like a good risk/reward trade-off.
This patch therefore restricts the MEM_EXPR comparison to base decls
only, excluding all MEM_REFs. It means we lose all the new STPs in
the PR testcase but keep the ones in the original stp_1.c testcase.
gcc/
PR target/104005
* config/aarch64/aarch64.cc (aarch64_check_consecutive_mems):
When using MEM_EXPR, require the base to be a decl.
gcc/testsuite/
PR target/104005
* gcc.target/aarch64/pr104005.c: New test.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104005] [12 Regression] Regression on aarch64+sve with -O2 -fPIC since r12-5204
2022-01-13 11:41 [Bug target/104005] New: Regression on arm+sve with -O2 -fPIC gilles.gouaillardet at gmail dot com
` (5 preceding siblings ...)
2022-01-18 12:20 ` cvs-commit at gcc dot gnu.org
@ 2022-01-18 12:22 ` rsandifo at gcc dot gnu.org
2022-01-19 8:25 ` gilles.gouaillardet at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2022-01-18 12:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104005
rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #6 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Fixed on trunk. Thanks for catching this before the GCC 12 release.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104005] [12 Regression] Regression on aarch64+sve with -O2 -fPIC since r12-5204
2022-01-13 11:41 [Bug target/104005] New: Regression on arm+sve with -O2 -fPIC gilles.gouaillardet at gmail dot com
` (6 preceding siblings ...)
2022-01-18 12:22 ` rsandifo at gcc dot gnu.org
@ 2022-01-19 8:25 ` gilles.gouaillardet at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: gilles.gouaillardet at gmail dot com @ 2022-01-19 8:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104005
--- Comment #7 from Gilles Gouaillardet <gilles.gouaillardet at gmail dot com> ---
Thanks Richard for the quick fix!
Unfortunately, I just found an other (and much older) issue (ICE, only at
-Ofast) I reported at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104112
^ permalink raw reply [flat|nested] 9+ messages in thread