[Bug testsuite/104023] New: Bulk rename of C++ test files to one filename extension ?

[Bug testsuite/104023] New: Bulk rename of C++ test files to one filename extension ?

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

            Bug ID: 104023
           Summary: Bulk rename of C++ test files to one filename
                    extension ?
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

I notice the following in the testsuite:

[/home/dcb/gcc/trunk.git/gcc/testsuite] $ find . -name \*.C -print | wc -l
18461
[/home/dcb/gcc/trunk.git/gcc/testsuite] $ find . -name \*.cc -print | wc -l
168
[/home/dcb/gcc/trunk.git/gcc/testsuite] $ find . -name \*.cpp -print | wc -l
23
[/home/dcb/gcc/trunk.git/gcc/testsuite] $ find . -name \*.cxx -print | wc -l
0
[/home/dcb/gcc/trunk.git/gcc/testsuite] $ 

Would it be a good idea to pick one filename extension for C++ testsuite files
and stick to it ?

Maybe moving to *.C would be cheap, but I notice that the main
parts of the compiler are moving to using *.cc, implying that 
over 18,000 files might have to be moved to *.cc

Just an idea. Given the amount of work involved, it might not be worth it.

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I think the testsuite only tests .C anyways. I am not in front of the computer
right now but you could check the .exp files to see if the other ones are
actually being tested.

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
it depends on the specific sub-harness which suffix is included in the globs
...

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-01-14
     Ever confirmed|0                           |1

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Yes, some of them are really considered, e.g.:

$ grep cc ./g++.dg/vect/*.exp
        $srcdir/$subdir/{pr,simd}*.{c,cc,S} ]] "" $DEFAULT_VECTCFLAGS
        $srcdir/$subdir/slp-pr*.{c,cc,S} ]] "" $VECT_SLP_CFLAGS

$ grep cpp ./gcc.target/avr/*exp
dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.{\[cCS\],cpp}]] \

But some of them are likely ignored.

I'm willing to rename .cpp and .cc files to .C, is it something we want to do?

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Oh no. We usually use .cpp/.cc extension as an additional file that is
intentionally skipped by a glob pattern:

$ head g++.target/i386/mv12.C
...
// { dg-additional-sources "mv12-aux.cc" }

or:

gcc/testsuite/g++.dg/asan/asan_test.C:#include "asan_str_test.cc"

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Working on that.

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Yeah, a lot of test directories rely on one extension for the test and another
for auxiliary sources.
Furthermore, e.g. for libraries inherited from upstreams, we should use
extensions those projects use rather than switching to something we choose.

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I'd say renaming the *.C in tests to something else would only bring pain and
no gain.

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

--- Comment #8 from Martin Liška <marxin at gcc dot gnu.org> ---
I have the following suggestion:

- require all C++ files in gcc/testsuite to have .C extension with the
following exceptions:

1) allow .cc and .cpp for tests of inherited projects (./gdc.test)
2) allow .cc extension for additional files not used directly, but require the
file ending with -aux.cc or -main.cc. Note quite some filenames do follow the
naming scheme

What do you think?

[Bug testsuite/104023] Bulk rename of C++ test files to one filename extension ?

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104023

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|marxin at gcc dot gnu.org          |unassigned at gcc dot gnu.org

--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
Leaving that are it does not make sense renaming thousands
of files to .cc (what we currently use for source code).