* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
@ 2022-01-14 9:17 ` pinskia at gcc dot gnu.org
2022-01-14 9:44 ` [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56 marxin at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-01-14 9:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|debug |c++
Target Milestone|--- |12.0
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note the difference is in the column number 14:16 vs 14:12.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
2022-01-14 9:17 ` [Bug c++/104025] " pinskia at gcc dot gnu.org
@ 2022-01-14 9:44 ` marxin at gcc dot gnu.org
2022-01-14 9:56 ` pinskia at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-01-14 9:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2022-01-14
Ever confirmed|0 |1
CC| |anthonysharp15 at gmail dot com,
| |marxin at gcc dot gnu.org
Status|UNCONFIRMED |NEW
Summary|[12 Regression] |[12 Regression]
|'-fcompare-debug' failure |'-fcompare-debug' failure
|with enabled warnings |with enabled warnings since
| |r12-6563-gb8ffa71e4271ae56
--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-6563-gb8ffa71e4271ae56.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
2022-01-14 9:17 ` [Bug c++/104025] " pinskia at gcc dot gnu.org
2022-01-14 9:44 ` [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56 marxin at gcc dot gnu.org
@ 2022-01-14 9:56 ` pinskia at gcc dot gnu.org
2022-01-17 12:32 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-01-14 9:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Obviously removing "&& warn_missing_template_keyword" will fix the
fcompare-debug but the question is which location is the more correct one?
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
` (2 preceding siblings ...)
2022-01-14 9:56 ` pinskia at gcc dot gnu.org
@ 2022-01-17 12:32 ` rguenth at gcc dot gnu.org
2022-01-17 18:55 ` jakub at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-01-17 12:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
` (3 preceding siblings ...)
2022-01-17 12:32 ` rguenth at gcc dot gnu.org
@ 2022-01-17 18:55 ` jakub at gcc dot gnu.org
2022-01-17 19:35 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-01-17 18:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Yeah, the reason that -fcompare-debug fails isn't that -g vs. -g0 would emit
different line number, but that -fcompare-debug uses -w for one of the
compilations so that warnings aren't emitted multiple times and so one
compilation is with -Wmissing-template-keyword and one without.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
` (4 preceding siblings ...)
2022-01-17 18:55 ` jakub at gcc dot gnu.org
@ 2022-01-17 19:35 ` jakub at gcc dot gnu.org
2022-01-17 22:40 ` jason at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-01-17 19:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52213
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52213&action=edit
gcc12-pr104025.patch
Untested fix. I think the old input_location is the right one.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
` (5 preceding siblings ...)
2022-01-17 19:35 ` jakub at gcc dot gnu.org
@ 2022-01-17 22:40 ` jason at gcc dot gnu.org
2022-01-18 12:34 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jason at gcc dot gnu.org @ 2022-01-17 22:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
--- Comment #6 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #5)
> Created attachment 52213 [details]
> gcc12-pr104025.patch
>
> Untested fix. I think the old input_location is the right one.
I think the bug is that cp_lexer_rollback_tokens isn't properly updating
input_location.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
` (6 preceding siblings ...)
2022-01-17 22:40 ` jason at gcc dot gnu.org
@ 2022-01-18 12:34 ` jakub at gcc dot gnu.org
2022-01-18 22:57 ` cvs-commit at gcc dot gnu.org
2022-01-18 22:58 ` jason at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-01-18 12:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Maybe. But how? Would it push a pair of next_token, input_location ?
I think it isn't easy to recompute input_location after the rollback otherwise.
And, I'm a little bit worried that such a change could be at this point quite
dangerous, while the above patch affects one spot that has changed, we have
lots of rollbacks in various places.
Anyway, patch passed bootstrap/regtest.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
` (7 preceding siblings ...)
2022-01-18 12:34 ` jakub at gcc dot gnu.org
@ 2022-01-18 22:57 ` cvs-commit at gcc dot gnu.org
2022-01-18 22:58 ` jason at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-01-18 22:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:
https://gcc.gnu.org/g:2aa184458a11a7ec8c1b451b8eeff458a24632bb
commit r12-6703-g2aa184458a11a7ec8c1b451b8eeff458a24632bb
Author: Jason Merrill <jason@redhat.com>
Date: Mon Jan 17 17:16:38 2022 -0500
c++: input_location and lookahead [PR104025]
Debug information was getting confused because input_location was different
depending on whether we had looked ahead to see if the next tokens look
like
a template argument list.
I tried resetting input_location in cp_lexer_rollback_tokens itself, but
that caused regressions, so let's just do it here for now.
PR c++/104025
gcc/cp/ChangeLog:
* parser.cc (saved_token_sentinel::rollback): Call
cp_lexer_set_source_position.
(~saved_token_sentinel): Call rollback.
gcc/testsuite/ChangeLog:
* g++.dg/warn/pr104025.C: New test.
Co-authored-by: Jakub Jelinek <jakub@redhat.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug c++/104025] [12 Regression] '-fcompare-debug' failure with enabled warnings since r12-6563-gb8ffa71e4271ae56
2022-01-14 9:05 [Bug debug/104025] New: [12 Regression] '-fcompare-debug' failure with enabled warnings zsojka at seznam dot cz
` (8 preceding siblings ...)
2022-01-18 22:57 ` cvs-commit at gcc dot gnu.org
@ 2022-01-18 22:58 ` jason at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: jason at gcc dot gnu.org @ 2022-01-18 22:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104025
Jason Merrill <jason at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #7)
> Maybe. But how? Would it push a pair of next_token, input_location ?
> I think it isn't easy to recompute input_location after the rollback
> otherwise.
> And, I'm a little bit worried that such a change could be at this point
> quite dangerous, while the above patch affects one spot that has changed, we
> have lots of rollbacks in various places.
Fair; doing it in saved_token_sentinel seemed like a reasonable compromise.
^ permalink raw reply [flat|nested] 11+ messages in thread