public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/104104] [12 Regression] Assembler messages: Error: number of operands mismatch for `vxorps'
Date: Wed, 19 Jan 2022 01:25:14 +0000	[thread overview]
Message-ID: <bug-104104-4-qSnU9aJhQV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104104-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104104

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:ddce00dba244d889d688490517fb106169a72f01

commit r12-6715-gddce00dba244d889d688490517fb106169a72f01
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 19 02:24:06 2022 +0100

    i386: Fix GLC tuning with -masm=intel [PR104104]

    > > On Sat, Jan 15, 2022 at 5:39 PM Hongyu Wang <wwwhhhyyy333@gmail.com>
wrote:
    > > > Thanks for the suggestion, here is the updated patch that survived
    > > > bootstrap/regtest.

    Unfortunately the patch results in assembler failures with -masm=intel.

    > > > > +  if (TARGET_DEST_FALSE_DEPENDENCY
    > > > > +      && get_attr_dest_false_dep (insn) ==
    > > > > +        DEST_FALSE_DEP_TRUE)
    > > > > +    output_asm_insn ("vxorps\t{%x0, %x0, %x0}", operands);

    All the vxorps insns were emitted like the above, which means for
-masm=sysv
    it looks like
            vxorps  %xmm3, %xmm3, %xmm3
    but for -masm=intel like:
            vxorps
    We want obviously
            vxorps  xmm3, xmm3, xmm3
    so the following patch just drops the errorneous {}s.

    2022-01-19  Jakub Jelinek  <jakub@redhat.com>

            PR target/104104
            * config/i386/sse.md
            (<avx512>_<complexopname>_<mode><maskc_name><round_name>,
           
avx512fp16_<complexopname>sh_v8hf<mask_scalarc_name><round_scalarcz_name>,
            avx512dq_mul<mode>3<mask_name>,
<avx2_avx512>_permvar<mode><mask_name>,
            avx2_perm<mode>_1<mask_name>, avx512f_perm<mode>_1<mask_name>,
            avx512dq_rangep<mode><mask_name><round_saeonly_name>,
            avx512dq_ranges<mode><mask_scalar_name><round_saeonly_scalar_name>,
            <avx512>_getmant<mode><mask_name><round_saeonly_name>,
           
avx512f_vgetmant<mode><mask_scalar_name><round_saeonly_scalar_name>):
            Use vxorps\t%x0, %x0, %x0 instead of vxorps\t{%x0, %x0, %x0}.

            * gcc.target/i386/pr104104.c: New test.

  parent reply	other threads:[~2022-01-19  1:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18 20:14 [Bug target/104104] New: " asolokha at gmx dot com
2022-01-18 20:28 ` [Bug target/104104] [12 Regression] " jakub at gcc dot gnu.org
2022-01-18 20:40 ` jakub at gcc dot gnu.org
2022-01-19  1:25 ` cvs-commit at gcc dot gnu.org [this message]
2022-01-19  1:25 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104104-4-qSnU9aJhQV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).