public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "nickhuang99 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/104113] invalid template argument causes the type to become int which confuses the rest of the diagnostic
Date: Fri, 21 Jan 2022 15:02:41 +0000	[thread overview]
Message-ID: <bug-104113-4-fE5NgOKyK4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104113-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104113

--- Comment #6 from qingzhe huang <nickhuang99 at hotmail dot com> ---
How about this simple fix? (see the patch above.) 
Instead of return "error_mark_node" by condition of
"!cp_parser_simulate_error", we now report error immediately. The rational of
this fix is that "cp_parser_simulate_error" is only making sense when we
already see error, i.e. "CP_PARSER_STATUS_KIND_ERROR". Otherwise, we should
just report error.
I did a full build and check, it seems fine with me. For example, 

104091.cpp: In function ‘void g()’:
104091.cpp:8:7: error: ‘auto’ not permitted in template argument
    8 |     A<auto> x = A<short>();
      |       ^~~~
104091.cpp:8:13: error: variable ‘A<auto> x’ has initializer but incomplete
type
    8 |     A<auto> x = A<short>();
      |             ^


Also I noticed previous testcase (i.e. g++.dg/DRs/dr625.C) is too relaxed with
error message by allowing inaccurate "invalid template argument" or "cannot
convert ..." instead of "auto not permitted".

If this makes sense to you, I am happy to provide more testcases and correct
those old testcases.

  parent reply	other threads:[~2022-01-21 15:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 10:46 [Bug c++/104113] New: DR 625 forbids "auto" being used in template argument and parser fails to issue correct error message for it nickhuang99 at hotmail dot com
2022-01-19 11:01 ` [Bug c++/104113] " pinskia at gcc dot gnu.org
2022-01-19 11:05 ` [Bug c++/104113] invalid template argument causes the type to become int which confuses the rest of the diagnostic pinskia at gcc dot gnu.org
2022-01-19 11:18 ` pinskia at gcc dot gnu.org
2022-01-19 11:21 ` pinskia at gcc dot gnu.org
2022-01-21 14:48 ` nickhuang99 at hotmail dot com
2022-01-21 15:02 ` nickhuang99 at hotmail dot com [this message]
2022-01-21 15:44 ` mpolacek at gcc dot gnu.org
2023-08-01  1:26 ` pinskia at gcc dot gnu.org
2023-08-01  1:29 ` pinskia at gcc dot gnu.org
2024-03-06  2:13 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104113-4-fE5NgOKyK4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).