From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 7829F3829BF7; Sun, 29 May 2022 19:12:56 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7829F3829BF7
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/104117] [9,10  Regression] Darwin ppc64 uses invalid
 non-PIC address to access constants (in PIC code).
Date: Sun, 29 May 2022 19:12:56 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 10.3.0
X-Bugzilla-Keywords: link-failure, ra, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-104117-4-sg8J2CAUpw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-104117-4@http.gcc.gnu.org/bugzilla/>
References: <bug-104117-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 May 2022 19:12:56 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104117

--- Comment #27 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:cfad91385ae0f92eedda1fff5f6f4b23da9f1f1b

commit r10-10796-gcfad91385ae0f92eedda1fff5f6f4b23da9f1f1b
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Mon Feb 7 15:36:35 2022 +0000

    Darwin, rs6000: Amend lo_sum use for forced constants [PR104117].

    Two issues resulted in this PR, which manifests when we force a constant
into
    memory in LRA (in PIC code on Darwin).  The presence of such forced
constants
    is quite dependent on other RTL optimisations, and it is easy for the i=
ssue
to
    become latent for a specific case.

    First, in the Darwin-specific rs6000 backend code, we were not being
careful
    enough in rejecting invalid symbolic addresses.  Specifically, when
generating
    PIC code, we require a SYMBOL_REF to be wrapped in an
UNSPEC_MACHOPIC_OFFSET.

    We now split the Darwin high/low selectors into two:
     1. One that handles non-PIC addresses (kernel mode, mdynamic-no-pic).
     2. One that handles PIC addresses and rejects SYMBOL_REFs unless they =
are
        suitably wrapped in the MACHOPIC_OFFSET unspec.

    The second case is handled by providing a new predicate (macho_pic_addr=
ess)
    that checks the requirements.

    Backported from 4c3792d448964f7bd99e7eac2c29c9eb7c2bfb84 and
    f1b3e3853329b58fb2e50c17487df2ecbc4a5608

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    Co-authored-by: Vladimir Makarov <vmakarov@redhat.com>

            PR target/104117

    gcc/ChangeLog:

            * config/rs6000/rs6000.c (darwin_rs6000_legitimate_lo_sum_const=
_p):
            Check for UNSPEC_MACHOPIC_OFFSET wrappers on symbolic addresses
when
            emitting PIC code.
            (legitimate_lo_sum_address_p): Likewise.
            (rs6000_legitimize_address): Do not apply the TLS processing to
            Darwin.
            * config/rs6000/darwin.md (@machopic_high_<mode>): New.
            (@machopic_low_<mode>): New.
            * config/rs6000/predicates.md (macho_pic_address): New.=