[Bug bootstrap/104134] New: Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[Bug bootstrap/104134] New: Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

            Bug ID: 104134
           Summary: Bootstrap on FreeBSD files compiling gcc/cp/error.cc
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: kargl at gcc dot gnu.org
  Target Milestone: ---

cc1-checksum.o libbackend.a main.o libcommon-target.a libcommon.a
../libcpp/libcpp.a ../libdecnumber/libdecnumber.a libcommon.a
../libcpp/libcpp.a  -liconv ../libbacktrace/.libs/libbacktrace.a
../libiberty/libiberty.a ../libdecnumber/libdecnumber.a  -lisl -L/usr/local/lib
-lmpc -lmpfr -lgmp -rdynamic  -L./../zlib -lz -lzstd 
/usr/home/sgk/gcc/objx/./prev-gcc/xg++ -B/usr/home/sgk/gcc/objx/./prev-gcc/
-B/usr/home/sgk/work/x/x86_64-unknown-freebsd14.0/bin/ -nostdinc++
-B/usr/home/sgk/gcc/objx/prev-x86_64-unknown-freebsd14.0/libstdc++-v3/src/.libs
-B/usr/home/sgk/gcc/objx/prev-x86_64-unknown-freebsd14.0/libstdc++-v3/libsupc++/.libs

-I/usr/home/sgk/gcc/objx/prev-x86_64-unknown-freebsd14.0/libstdc++-v3/include/x86_64-unknown-freebsd14.0
 -I/usr/home/sgk/gcc/objx/prev-x86_64-unknown-freebsd14.0/libstdc++-v3/include 
-I/usr/home/sgk/gcc/gccx/libstdc++-v3/libsupc++
-L/usr/home/sgk/gcc/objx/prev-x86_64-unknown-freebsd14.0/libstdc++-v3/src/.libs
-L/usr/home/sgk/gcc/objx/prev-x86_64-unknown-freebsd14.0/libstdc++-v3/libsupc++/.libs
 -fno-PIE -c  -DIN_GCC_FRONTEND -g -O2 -fno-checking -gtoggle -DIN_GCC    
-fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing
-Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual
-pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror
-fno-common  -DHAVE_CONFIG_H -I. -Icp -I../../gccx/gcc -I../../gccx/gcc/cp
-I../../gccx/gcc/../include -I../../gccx/gcc/../libcpp/include
-I../../gccx/gcc/../libcody -I/usr/local/include 
-I../../gccx/gcc/../libdecnumber -I../../gccx/gcc/../libdecnumber/dpd
-I../libdecnumber -I../../gccx/gcc/../libbacktrace   -o cp/error.o -MT
cp/error.o -MMD -MP -MF cp/.deps/error.TPo ../../gccx/gcc/cp/error.cc
In file included from ../../gccx/gcc/cp/error.cc:29:
../../gccx/gcc/cp/error.cc: In function 'void
dump_aggr_type(cxx_pretty_printer*, tree, int)':
../../gccx/gcc/cp/error.cc:841:27: error: spurious leading punctuation sequence
'<' in format [-Werror=format-diag]
  841 |         pp_printf (pp, M_("<unnamed %s>"), variety);
../../gccx/gcc/intl.h:40:26: note: in definition of macro 'gettext'
   40 | # define gettext(msgid) (msgid)
      |                          ^~~~~
../../gccx/gcc/cp/error.cc:52:56: note: in expansion of macro '_'
   52 | #define M_(msgid) (pp_translate_identifiers (cxx_pp) ? _(msgid) :
(msgid))
      |                                                        ^
../../gccx/gcc/cp/error.cc:841:24: note: in expansion of macro 'M_'
  841 |         pp_printf (pp, M_("<unnamed %s>"), variety);
      |                        ^~
../../gccx/gcc/cp/error.cc:841:27: error: spurious trailing punctuation
sequence '>' in format [-Werror=format-diag]
  841 |         pp_printf (pp, M_("<unnamed %s>"), variety);
../../gccx/gcc/intl.h:40:26: note: in definition of macro 'gettext'
   40 | # define gettext(msgid) (msgid)
      |                          ^~~~~
../../gccx/gcc/cp/error.cc:52:56: note: in expansion of macro '_'
   52 | #define M_(msgid) (pp_translate_identifiers (cxx_pp) ? _(msgid) :
(msgid))
      |                                                        ^
../../gccx/gcc/cp/error.cc:841:24: note: in expansion of macro 'M_'
  841 |         pp_printf (pp, M_("<unnamed %s>"), variety);
      |                        ^~
cc1plus: all warnings being treated as errors

[Bug bootstrap/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug bootstrap/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #1 from kargl at gcc dot gnu.org ---
Removing the '<' and '>' characters allows bootstrap to continue.
Probably not the desired patch.

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Host|                            |*-*-*freebsd*
             Target|                            |*-*-*freebsd*
           Keywords|                            |build, diagnostic
          Component|bootstrap                   |c++
              Build|                            |*-*-*freebsd*
   Target Milestone|---                         |12.0

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at gcc dot gnu.org

--- Comment #2 from Martin Sebor <msebor at gcc dot gnu.org> ---
Did the file compile without these warnings prior to r12-6729?

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #3 from kargl at gcc dot gnu.org ---
(In reply to Martin Sebor from comment #2)
> Did the file compile without these warnings prior to r12-6729?

Yes (with the caveat I don't know if error.c was renamed to error.cc
during the great *.c renaming event).

I simply changed < and > to a single quote and everything built
as expected.

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
For this PR, I guess the big question is what is different between FreeBSD and
Linux that it triggers on the former and not on the latter.
Can you please upload preprocessed cp/error.ii so that we can compare it
against what we have on Linux?  Thanks.

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The file uses
#if __GNUC__ >= 10
#  pragma GCC diagnostic push
#  pragma GCC diagnostic ignored "-Wformat-diag"
#endif
...
#if __GNUC__ >= 10
#  pragma GCC diagnostic pop
#endif
but in a region different from what is reported about.

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #6 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Wed, Jan 19, 2022 at 11:54:25PM +0000, jakub at gcc dot gnu.org wrote:
> 
> --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> For this PR, I guess the big question is what is different between FreeBSD and
> Linux that it triggers on the former and not on the latter.
> Can you please upload preprocessed cp/error.ii so that we can compare it
> against what we have on Linux?  Thanks.
> 

See attached.

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #7 from kargl at gcc dot gnu.org ---
Created attachment 52237
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52237&action=edit
gzipped error.ii

Seems bugzilla stripped the attachment which was 2.6 MB

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #8 from kargl at gcc dot gnu.org ---
(In reply to Jakub Jelinek from comment #5)
> The file uses
> #if __GNUC__ >= 10
> #  pragma GCC diagnostic push
> #  pragma GCC diagnostic ignored "-Wformat-diag"
> #endif
> ...
> #if __GNUC__ >= 10
> #  pragma GCC diagnostic pop
> #endif
> but in a region different from what is reported about.

Note, I configured gcc to use gcc 11.2 to be the initial bootstrap compiler.

% gcc11 --version
gcc11 (FreeBSD Ports Collection) 11.2.0
% cat confx
#! /bin/sh

CC=/usr/local/bin/gcc11
export CC
CXX=/usr/local/bin/g++11
export CXX
LD_LIBRARY_PATH=/usr/local/lib/gcc11
export LD_LIBRARY_PATH
LD_RUN_PATH=/usr/local/lib/gcc11
export LD_RUN_PATH

../gccx/configure --prefix=$HOME/work/x --enable-languages=c,c++,fortran,lto \
  --enable-bootstrap --disable-nls --enable-checking

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #9 from Martin Sebor <msebor at gcc dot gnu.org> ---
The code uses the M_ macro:

  pp_printf (pp, M_("<unnamed %s>"), variety);

on my machine it expands into:

  pp_printf (pp, ((cxx_pp)->translate_identifiers ? gettext ("<unnamed %s>") :
("<unnamed %s>")), variety);

and GCC doesn't warn most likely because the front end doesn't see through the
complex expressio.  If I remove the M_ it does warn.  So in the FreeBSD build
the M_() macro probably expands to its argument (the string) which GCC then
warns on.

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #10 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Jan 20, 2022 at 12:25:35AM +0000, msebor at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134
> 
> --- Comment #9 from Martin Sebor <msebor at gcc dot gnu.org> ---
> The code uses the M_ macro:
> 
>   pp_printf (pp, M_("<unnamed %s>"), variety);
> 
> on my machine it expands into:
> 
>   pp_printf (pp, ((cxx_pp)->translate_identifiers ? gettext ("<unnamed %s>") :
> ("<unnamed %s>")), variety);
> 
> and GCC doesn't warn most likely because the front end doesn't see through the
> complex expressio.  If I remove the M_ it does warn.  So in the FreeBSD build
> the M_() macro probably expands to its argument (the string) which GCC then
> warns on.
> 

Yes, that seems to be what is happening.  I posted the error.ii
file.  I don't see that gettext in the relevant line of code.

Note, I justed started a bootstrap with FreeBSD system compiler
clang/clang++.  I'll report back later if it dies or succeeds.

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
In the FreeBSD case it is:
pp_printf (pp, ((cxx_pp)->translate_identifiers ? ("<unnamed %s>") : ("<unnamed
%s>")), variety);
so no translation.

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #12 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Jan 20, 2022 at 12:29:18AM +0000, sgk at troutmask dot
apl.washington.edu wrote:
> 
> Note, I justed started a bootstrap with FreeBSD system compiler
> clang/clang++.  I'll report back later if it dies or succeeds.
> 

Well, that was a disaster.

% gmake bootstrap
...
ld: error: unable to find library -lc
collect2: error: ld returned 1 exit status
gmake[3]: *** [Makefile:995: libgcc_s.so] Error 1
gmake[3]: Leaving directory
'/usr/home/sgk/gcc/objx/x86_64-unknown-freebsd14.0/libgcc'
% which ld
/usr/local/bin/ld
% ld --version
GNU ld (GNU Binutils) 2.37

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[rimvydas.jas at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

Rimvydas (RJ) <rimvydas.jas at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rimvydas.jas at gmail dot com

--- Comment #13 from Rimvydas (RJ) <rimvydas.jas at gmail dot com> ---
Error is triggered on Linux (LFS-next testing) builds too, but only when
configured as:
../configure --enable-bootstrap --disable-nls --disable-multilib

Host compiler is GCC v12 few commits before the
g:34ba4275dcf5162efb9b634e4665734766faf4e3 (already had this warning).

Happens only during stage2 (and stage3) build, when executing:
/tmp/build/./prev-gcc/xg++ -B/tmp/build/./prev-gcc/ [...] -fno-PIE -c
-DIN_GCC_FRONTEND -g -O2 -fno-checking -gtoggle -DIN_GCC -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common
-DHAVE_CONFIG_H -I. [...] -o cp/error.o -MT cp/error.o -MMD -MP -MF
cp/.deps/error.TPo /root/gcc_master/gcc/cp/error.cc

[Bug c++/104134] Bootstrap on FreeBSD files compiling gcc/cp/error.cc

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #14 from kargl at gcc dot gnu.org ---
(In reply to Rimvydas (RJ) from comment #13)
> Error is triggered on Linux (LFS-next testing) builds too, but only when
> configured as:
> ../configure --enable-bootstrap --disable-nls --disable-multilib
> 

Removing --disable-nls from my configure command line allows bootstrap to
succeed on FreeBSD.

[Bug c++/104134] Bootstrap with --disable-nls compiling gcc/cp/error.cc

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-01-20
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #15 from Martin Liška <marxin at gcc dot gnu.org> ---
I have a patch candidate.

[Bug c++/104134] Bootstrap with --disable-nls compiling gcc/cp/error.cc

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:6d51a27fb17d9dc4e583c119fd976d39e575180f

commit r12-6760-g6d51a27fb17d9dc4e583c119fd976d39e575180f
Author: Martin Liska <mliska@suse.cz>
Date:   Thu Jan 20 09:30:01 2022 +0100

    Fix Werror=format-diag with --disable-nls.

            PR c++/104134

    gcc/cp/ChangeLog:

            * error.cc (dump_aggr_type): Partially disable the warning.

[Bug c++/104134] Bootstrap with --disable-nls compiling gcc/cp/error.cc

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104134

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #17 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.