[Bug bootstrap/104135] New: [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[Bug bootstrap/104135] New: [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104135

            Bug ID: 104135
           Summary: [12 Regression] -Werror=format-diag breaks rtl
                    checking bootstrap
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

>From what I can see, the errors were before it was turned into error:
        ../../gcc/emit-rtl.cc:4000:25: warning: unquoted identifier or keyword
‘emit_insn’ in format [-Wformat-diag]
        ../../gcc/emit-rtl.cc:4000:46: warning: unquoted identifier or keyword
‘emit_jump_insn’ in format [-Wformat-diag]
        ../../gcc/emit-rtl.cc:4000:68: warning: unquoted whitespace character
‘\x0a’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:888:42: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:888:53: warning: unterminated quote character ‘'’ in
format [-Wformat-diag]
        ../../gcc/rtl.cc:898:50: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:898:61: warning: unterminated quote character ‘'’ in
format [-Wformat-diag]
        ../../gcc/rtl.cc:907:48: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:907:59: warning: unterminated quote character ‘'’ in
format [-Wformat-diag]
        ../../gcc/rtl.cc:917:43: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:917:54: warning: unterminated quote character ‘'’ in
format [-Wformat-diag]
        ../../gcc/rtl.cc:928:35: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:928:49: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/emit-rtl.cc:4000:25: warning: unquoted identifier or keyword
‘emit_insn’ in format [-Wformat-diag]
        ../../gcc/emit-rtl.cc:4000:46: warning: unquoted identifier or keyword
‘emit_jump_insn’ in format [-Wformat-diag]
        ../../gcc/emit-rtl.cc:4000:68: warning: unquoted whitespace character
‘\x0a’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:888:42: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:888:53: warning: unterminated quote character ‘'’ in
format [-Wformat-diag]
        ../../gcc/rtl.cc:898:50: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:898:61: warning: unterminated quote character ‘'’ in
format [-Wformat-diag]
        ../../gcc/rtl.cc:907:48: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:907:59: warning: unterminated quote character ‘'’ in
format [-Wformat-diag]
        ../../gcc/rtl.cc:917:43: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:917:54: warning: unterminated quote character ‘'’ in
format [-Wformat-diag]
        ../../gcc/rtl.cc:928:35: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
        ../../gcc/rtl.cc:928:49: warning: unquoted sequence of 2 consecutive
punctuation characters ‘',’ in format [-Wformat-diag]
but now it fails the bootstrap.
../configure --enable-languages=default,ada,obj-c++,lto,go,d
--enable-checking=yes,rtl,extra --enable-libstdcxx-backtrace=yes
is what I'm using on x86_64-linux.

[Bug bootstrap/104135] [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104135

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
           Priority|P3                          |P1

[Bug bootstrap/104135] [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104135

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #1 from kargl at gcc dot gnu.org ---
PR 104134 might be a duplicate of this PR.

[Bug bootstrap/104135] [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104135

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
No, that is a different problem with the same warning now turned into error.

[Bug bootstrap/104135] [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104135

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at gcc dot gnu.org

--- Comment #3 from Martin Sebor <msebor at gcc dot gnu.org> ---
The first warning looks legit.  The code it points to is guarded by #ifdef
ENABLE_RTL_CHECKING.  Maybe Martin tested without the macro.

[Bug bootstrap/104135] [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104135

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-01-20

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Let me handle this, sorry for the breakage.

[Bug bootstrap/104135] [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104135

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:e744aa373d215d1e8b3f4102a71b26b385dababc

commit r12-6759-ge744aa373d215d1e8b3f4102a71b26b385dababc
Author: Martin Liska <mliska@suse.cz>
Date:   Thu Jan 20 09:28:42 2022 +0100

    Fix -Werror=format-diag with RTL checking

            PR bootstrap/104135

    gcc/ChangeLog:

            * emit-rtl.cc (make_insn_raw): Fix -Wformat-diag warnings.
            * rtl.cc: Partially disable -Wformat-diag for RTL checking
            error messages.

[Bug bootstrap/104135] [12 Regression] -Werror=format-diag breaks rtl checking bootstrap

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104135

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.