public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/104158] [12 Regression] gcc no longer accepts -fsanitize-coverage=trace-pc,trace-cmp since r12-1177
Date: Mon, 24 Jan 2022 10:54:05 +0000	[thread overview]
Message-ID: <bug-104158-4-FLluLu1W0p@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104158-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104158

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0ebb09f5e49c8ca06728bb791415d985df01f6d8

commit r12-6842-g0ebb09f5e49c8ca06728bb791415d985df01f6d8
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Jan 24 11:53:08 2022 +0100

    options: Add EnumBitSet property support [PR104158]

    On Sat, Jan 22, 2022 at 01:47:08AM +0100, Jakub Jelinek via Gcc-patches
wrote:
    > I think with the 2) patch I achieve what we want for Fortran, for 1)
    > the only behavior from gcc 11 is that
    > -fsanitize-coverage=trace-cmp,trace-cmp is now rejected.
    > This is mainly from the desire to disallow
    > -fconvert=big-endian,little-endian or -Wbidi-chars=bidirectional,any
    > etc. where it would be confusing to users what exactly it means.
    > But it is the only from these options that actually acts as an Enum
    > bit set, each enumerator can be specified with all the others.
    > So one option would be stop requiring the EnumSet implies Set properties
    > must be specified and just require that either they are specified on all
    > EnumValues, or on none of them; the latter case would be for
    > -fsanitize-coverage= and the non-Set case would mean that all the
    > EnumValues need to have disjoint Value bitmasks and that they can
    > be all specified and unlike the Set case also repeated.
    > Thoughts on this?

    Here is an incremental patch to the first two patches of the series
    that implements EnumBitSet that fully restores the -fsanitize-coverage
    GCC 11 behavior.

    2022-01-24  Jakub Jelinek  <jakub@redhat.com>

            PR sanitizer/104158
            * opt-functions.awk (var_set): Handle EnumBitSet property.
            * optc-gen.awk: Don't disallow RejectNegative if EnumBitSet is
            specified.
            * opts.h (enum cl_enum_var_value): New type.
            * opts-common.cc (decode_cmdline_option): Use CLEV_* values.
            Handle CLEV_BITSET.
            (cmdline_handle_error): Handle CLEV_BITSET.
            * opts.cc (test_enum_sets): Also test EnumBitSet requirements.
            * doc/options.texi (EnumBitSet): Document.
            * common.opt (fsanitize-coverage=): Use EnumBitSet instead of
            EnumSet.
            (trace-pc, trace-cmp): Drop Set properties.

            * gcc.dg/sancov/pr104158-7.c: Adjust for repeating of arguments
            being allowed.

  parent reply	other threads:[~2022-01-24 10:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21  9:53 [Bug sanitizer/104158] New: " jakub at gcc dot gnu.org
2022-01-21  9:53 ` [Bug sanitizer/104158] " jakub at gcc dot gnu.org
2022-01-21  9:56 ` pinskia at gcc dot gnu.org
2022-01-21 10:29 ` rjones at redhat dot com
2022-01-21 12:03 ` jakub at gcc dot gnu.org
2022-01-21 12:51 ` marxin at gcc dot gnu.org
2022-01-21 19:31 ` jakub at gcc dot gnu.org
2022-01-21 19:33 ` jakub at gcc dot gnu.org
2022-01-21 19:33 ` jakub at gcc dot gnu.org
2022-01-24 10:53 ` cvs-commit at gcc dot gnu.org
2022-01-24 10:53 ` cvs-commit at gcc dot gnu.org
2022-01-24 10:54 ` cvs-commit at gcc dot gnu.org [this message]
2022-01-24 11:02 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104158-4-FLluLu1W0p@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).