public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug bootstrap/104170] New: [12 Regression] Failed to bootstrap by r12-6807
@ 2022-01-21 20:08 hjl.tools at gmail dot com
2022-01-21 20:08 ` [Bug bootstrap/104170] " hjl.tools at gmail dot com
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: hjl.tools at gmail dot com @ 2022-01-21 20:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104170
Bug ID: 104170
Summary: [12 Regression] Failed to bootstrap by r12-6807
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: bootstrap
Assignee: unassigned at gcc dot gnu.org
Reporter: hjl.tools at gmail dot com
Target Milestone: ---
Target: i686
r12-6807 has
#if HAVE_GAS_CFI_PERSONALITY_DIRECTIVE && OPTION_GLIBC
OPTION_GLIBC can't be used here since OPTION_GLIBC is
evaluated at run-time:
https://gcc.gnu.org/pipermail/gcc-regression/2022-January/076271.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug bootstrap/104170] [12 Regression] Failed to bootstrap by r12-6807 2022-01-21 20:08 [Bug bootstrap/104170] New: [12 Regression] Failed to bootstrap by r12-6807 hjl.tools at gmail dot com @ 2022-01-21 20:08 ` hjl.tools at gmail dot com 2022-01-21 21:32 ` hjl.tools at gmail dot com ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: hjl.tools at gmail dot com @ 2022-01-21 20:08 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104170 H.J. Lu <hjl.tools at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Last reconfirmed| |2022-01-21 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/104170] [12 Regression] Failed to bootstrap by r12-6807 2022-01-21 20:08 [Bug bootstrap/104170] New: [12 Regression] Failed to bootstrap by r12-6807 hjl.tools at gmail dot com 2022-01-21 20:08 ` [Bug bootstrap/104170] " hjl.tools at gmail dot com @ 2022-01-21 21:32 ` hjl.tools at gmail dot com 2022-01-21 22:36 ` cvs-commit at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: hjl.tools at gmail dot com @ 2022-01-21 21:32 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104170 H.J. Lu <hjl.tools at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |12.0 --- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> --- A patch is posted at https://gcc.gnu.org/pipermail/gcc-patches/2022-January/589060.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/104170] [12 Regression] Failed to bootstrap by r12-6807 2022-01-21 20:08 [Bug bootstrap/104170] New: [12 Regression] Failed to bootstrap by r12-6807 hjl.tools at gmail dot com 2022-01-21 20:08 ` [Bug bootstrap/104170] " hjl.tools at gmail dot com 2022-01-21 21:32 ` hjl.tools at gmail dot com @ 2022-01-21 22:36 ` cvs-commit at gcc dot gnu.org 2022-01-22 0:02 ` hjl.tools at gmail dot com 2022-01-24 10:18 ` cvs-commit at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-01-21 22:36 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104170 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>: https://gcc.gnu.org/g:60953a23d57b13a672f751bec0c6eefc059eb1ab commit r12-6811-g60953a23d57b13a672f751bec0c6eefc059eb1ab Author: H.J. Lu <hjl.tools@gmail.com> Date: Fri Jan 21 13:24:00 2022 -0800 x86: Properly disable -fsplit-stack support on non-glibc targets Revert x86 changes in commit c163647ffbc9a20c8feb6e079dbecccfe016c82e Author: Soren Tempel <soeren@soeren-tempel.net> Date: Fri Jan 21 19:22:46 2022 +0000 Disable -fsplit-stack support on non-glibc targets and change ix86_supports_split_stack to return true only on glibc. PR bootstrap/104170 * common/config/i386/i386-common.cc (ix86_supports_split_stack): Return true only on glibc. * config/i386/gnu-user-common.h (STACK_CHECK_STATIC_BUILTIN): Revert commit c163647ffbc. * config/i386/gnu.h (TARGET_LIBC_PROVIDES_SSP): Likewise. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/104170] [12 Regression] Failed to bootstrap by r12-6807 2022-01-21 20:08 [Bug bootstrap/104170] New: [12 Regression] Failed to bootstrap by r12-6807 hjl.tools at gmail dot com ` (2 preceding siblings ...) 2022-01-21 22:36 ` cvs-commit at gcc dot gnu.org @ 2022-01-22 0:02 ` hjl.tools at gmail dot com 2022-01-24 10:18 ` cvs-commit at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: hjl.tools at gmail dot com @ 2022-01-22 0:02 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104170 H.J. Lu <hjl.tools at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> --- Fixed. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/104170] [12 Regression] Failed to bootstrap by r12-6807 2022-01-21 20:08 [Bug bootstrap/104170] New: [12 Regression] Failed to bootstrap by r12-6807 hjl.tools at gmail dot com ` (3 preceding siblings ...) 2022-01-22 0:02 ` hjl.tools at gmail dot com @ 2022-01-24 10:18 ` cvs-commit at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-01-24 10:18 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104170 --- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:2c31a8be4a5db11a0a0e97c366dded6362421086 commit r12-6838-g2c31a8be4a5db11a0a0e97c366dded6362421086 Author: Jakub Jelinek <jakub@redhat.com> Date: Mon Jan 24 11:13:39 2022 +0100 properly disable -fsplit-stack on non-glibc targets [PR104170] On Sat, Jan 22, 2022 at 10:32:21AM +0100, Martin LiÅ¡ka wrote: > I've just noticed the patch broke a few cross compilers: > > s390x-ibm-tpf: > > /home/marxin/buildworker/zen2-cross-compilers/build/gcc/common/config/s390/s390-common.cc: In function âbool s390_supports_split_stack(bool, gcc_options*)â: > /home/marxin/buildworker/zen2-cross-compilers/build/gcc/common/config/s390/s390-common.cc:126:13: error: âstruct gcc_optionsâ has no member named âx_linux_libcâ > 126 | if (opts->x_linux_libc == LIBC_GLIBC) > | ^~~~~~~~~~~~ > > i686-kopensolaris-gnu, i686-symbolics-gnu > > /home/marxin/buildworker/zen2-cross-compilers/build/gcc/common/config/i386/i386-common.cc: In function âbool ix86_supports_split_stack(bool, gcc_options*)â: > /home/marxin/buildworker/zen2-cross-compilers/build/gcc/common/config/i386/i386-common.cc:1721:13: error: âstruct gcc_optionsâ has no member named âx_linux_libcâ > 1721 | if (opts->x_linux_libc != LIBC_GLIBC) > | ^~~~~~~~~~~~ > make[1]: *** [Makefile:2418: i386-common.o] Error 1 > > Can you please take a look? Btw. do you have a bugzilla account? I bet instead of opts->x_linux_libc != LIBC_GLIBC it needs to use #ifdef OPTION_GLIBC if (!OPTION_GLIBC) #endif or so. I think the first committed patch actually used that but used it in #if directive, which is wrong because it is something that needs to be evaluated at runtime. That doesn't work well either, because the *supports_split_stack hooks have opts argument and OPTION_GLIBC doesn't take that. So, here is a patch that introduces OPTION_*_P macros that take opts as an argument and redefines OPTION_* using those (similarly to how the option scripts create TARGET_*_P and TARGET_* macros). 2022-01-24 Jakub Jelinek <jakub@redhat.com> PR bootstrap/104170 * config/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, OPTION_BIONIC_P, OPTION_MUSL_P): Define. (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine using OPTION_*_P macros. * config/alpha/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, OPTION_BIONIC_P, OPTION_MUSL_P): Define. (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine using OPTION_*_P macros. * config/rs6000/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, OPTION_BIONIC_P, OPTION_MUSL_P): Define. (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine using OPTION_*_P macros. * config/rs6000/linux64.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, OPTION_BIONIC_P, OPTION_MUSL_P): Define. (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine using OPTION_*_P macros. * config/fuchsia.h (OPTION_MUSL_P): Redefine. * config/glibc-stdint.h (OPTION_MUSL_P): Define if not defined. * common/config/s390/s390-common.cc (s390_supports_split_stack): Re-add ATTRIBUTE_UNUSED to opts parameter. If OPTION_GLIBC_P is defined, use OPTION_GLIBC_P (opts) as condition, otherwise assume if (false). * common/config/i386/i386-common.cc (ix86_supports_split_stack): If OPTION_GLIBC_P is defined use !OPTION_GLIBC_P (opts) as condition, otherwise assume if (true). ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-24 10:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-01-21 20:08 [Bug bootstrap/104170] New: [12 Regression] Failed to bootstrap by r12-6807 hjl.tools at gmail dot com 2022-01-21 20:08 ` [Bug bootstrap/104170] " hjl.tools at gmail dot com 2022-01-21 21:32 ` hjl.tools at gmail dot com 2022-01-21 22:36 ` cvs-commit at gcc dot gnu.org 2022-01-22 0:02 ` hjl.tools at gmail dot com 2022-01-24 10:18 ` cvs-commit at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).