public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kvr000 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/104188] gcc omitting AVX-512 broadcast instruction
Date: Sat, 22 Jan 2022 18:36:29 +0000	[thread overview]
Message-ID: <bug-104188-4-xPktgIUrtF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104188-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104188

--- Comment #4 from Zbynek Vyskovsky <kvr000 at gmail dot com> ---
Sure, the code:

#include <stdio.h>

#ifndef NO_VECTORIZE
#ifdef __x86_64__
#include <immintrin.h>
#include <x86intrin.h>
#endif
#ifdef __aarch64__
#include <arm_neon.h>
#endif
#endif

typedef union Mat44 {
        float m[4][4];
#ifndef NO_VECTORIZE
#ifdef __x86_64__
        __m128 row[4];
        __m256 rowDuet[2];
        __m512 rowQuad;
#endif
#ifdef __aarch64__
        float32x4_t row[4];
#endif
#endif
} Mat44;

__attribute__((noipa)) void matmult_avx512(union Mat44 *out, const Mat44 *a,
const Mat44 *b)
{
        __m512 a0123 = _mm512_loadu_ps(a->m[0]);
        __m512 b0000 = _mm512_broadcast_f32x4(b->row[0]);
        __m512 b1111 = _mm512_broadcast_f32x4(b->row[1]);
        __m512 b2222 = _mm512_broadcast_f32x4(b->row[2]);
        __m512 b3333 = _mm512_broadcast_f32x4(b->row[3]);

        __m512 result = _mm512_mul_ps(_mm512_permute_ps(a0123, 0x00), b0000);
        result = _mm512_fmadd_ps(_mm512_permute_ps(a0123, 0x55), b1111,
result);
        result = _mm512_fmadd_ps(_mm512_permute_ps(a0123, 0xaa), b2222,
result);
        result = _mm512_fmadd_ps(_mm512_permute_ps(a0123, 0xff), b3333,
result);

        _mm512_storeu_ps(out->m[0], result);
}

__attribute__((noipa)) void matmult_ref(Mat44 *out, const Mat44 *a, const Mat44
*b)
{
        Mat44 t;
        for (int i = 0; i < 4; i++) {
                for (int j = 0; j < 4; j++) {
                        t.m[i][j] = a->m[i][0]*b->m[0][j] +
a->m[i][1]*b->m[1][j] + a->m[i][2]*b->m[2][j] + a->m[i][3]*b->m[3][j];
                }
        }

        *out = t;
}

int main(void)
{
        Mat44 in = { m: { { 1, 2, 3, 4 }, { 5, 6, 7, 8 }, { 9, 10, 11, 12 }, {
13, 14, 15, 16 } } };
        Mat44 avx512_out;
        Mat44 ref_out;
        matmult_ref(&ref_out, &in, &in);
        matmult_avx512(&avx512_out, &in, &in);
        for (int r = 0; r < 4; ++r) {
                printf("%5.0f %5.0f %5.0f %5.0f      %5.0f %5.0f %5.0f
%5.0f\n", avx512_out.m[r][0], avx512_out.m[r][1], avx512_out.m[r][2],
avx512_out.m[r][3], ref_out.m[r][0], ref_out.m[r][1], ref_out.m[r][2],
ref_out.m[r][3]);
        }
        return 0;
}


Output (note the repeating first column on first side, caused by duplicating
single element instead of four):

  90    90    90    90         90   100   110   120
 202   202   202   202        202   228   254   280
 314   314   314   314        314   356   398   440
 426   426   426   426        426   484   542   600

  parent reply	other threads:[~2022-01-22 18:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-22 17:03 [Bug target/104188] New: " kvr000 at gmail dot com
2022-01-22 17:40 ` [Bug target/104188] " pinskia at gcc dot gnu.org
2022-01-22 17:49 ` kvr000 at gmail dot com
2022-01-22 17:55 ` jakub at gcc dot gnu.org
2022-01-22 18:36 ` kvr000 at gmail dot com [this message]
2022-01-22 18:50 ` jakub at gcc dot gnu.org
2022-01-22 19:00 ` [Bug target/104188] [11/12 Regression] " jakub at gcc dot gnu.org
2022-01-22 19:23 ` hjl.tools at gmail dot com
2022-01-22 19:51 ` hjl.tools at gmail dot com
2022-01-22 22:25 ` hjl.tools at gmail dot com
2022-01-22 23:29 ` kvr000 at gmail dot com
2022-01-23 18:37 ` hjl.tools at gmail dot com
2022-01-24  0:43 ` cvs-commit at gcc dot gnu.org
2022-01-24  0:47 ` cvs-commit at gcc dot gnu.org
2022-01-24  0:48 ` hjl.tools at gmail dot com
2022-01-26 11:00 ` cvs-commit at gcc dot gnu.org
2022-01-26 11:07 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104188-4-xPktgIUrtF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).