[Bug fortran/104210] New: [11/12 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685

[Bug fortran/104210] New: [11/12 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

            Bug ID: 104210
           Summary: [11/12 Regression] ICE in gfc_zero_size_array, at
                    fortran/arith.cc:1685
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20200628 and 20200705 :
(both with -fcoarray=single and -fcoarray=lib)


$ cat z1.f90
function f()
   integer :: f[*]
end
program p
   interface
      function f()
         integer :: f[*]
      end
   end interface
end


$ cat z2.f90
function f()
   integer :: f(2)[*]
end
program p
   interface
      function f()
         integer :: f(2)[*]
      end
   end interface
end


$ gfortran-12-20220123 -c z1.f90 -fcoarray=lib
z1.f90:1:0:

    1 | function f()
      |
Error: Function result 'f' at (1) shall not be a coarray or have a coarray
component
z1.f90:6:6:

    6 |       function f()
      |      1
Error: Function result 'f' at (1) shall not be a coarray or have a coarray
component
f951: internal compiler error: Segmentation fault
0xe6bd5f crash_signal
        ../../gcc/toplev.cc:322
0x6f5815 gfc_zero_size_array
        ../../gcc/fortran/arith.cc:1685
0x6f5815 reduce_binary0
        ../../gcc/fortran/arith.cc:1699
0x6f5815 eval_intrinsic_f3
        ../../gcc/fortran/arith.cc:1751
0x73af4d gfc_check_result_characteristics(gfc_symbol*, gfc_symbol*, char*, int)
        ../../gcc/fortran/interface.cc:1664
0x73b3c8 gfc_compare_interfaces(gfc_symbol*, gfc_symbol*, char const*, int,
int, char*, int, char const*, char const*, bool*)
        ../../gcc/fortran/interface.cc:1745
0x8a337b check_against_globals
        ../../gcc/fortran/frontend-passes.cc:5834
0x7c9922 do_traverse_symtree
        ../../gcc/fortran/symbol.cc:4174
0x8aa8b1 gfc_check_externals(gfc_namespace*)
        ../../gcc/fortran/frontend-passes.cc:5874
0x791522 gfc_parse_file()
        ../../gcc/fortran/parse.cc:6869
0x7df71f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:216

[Bug fortran/104210] [11/12 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |11.3

[Bug fortran/104210] [11/12 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685 since r11-1814-gcc9a9229285a26ac

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
            Summary|[11/12 Regression] ICE in   |[11/12 Regression] ICE in
                   |gfc_zero_size_array, at     |gfc_zero_size_array, at
                   |fortran/arith.cc:1685       |fortran/arith.cc:1685 since
                   |                            |r11-1814-gcc9a9229285a26ac
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-01-25
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |tkoenig at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-1814-gcc9a9229285a26ac.

[Bug fortran/104210] [11/12 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685 since r11-1814-gcc9a9229285a26ac

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Testing this patch:

diff --git a/gcc/fortran/arith.cc b/gcc/fortran/arith.cc
index 06e032e22db..204fc433dff 100644
--- a/gcc/fortran/arith.cc
+++ b/gcc/fortran/arith.cc
@@ -1489,6 +1489,9 @@ eval_intrinsic (gfc_intrinsic_op op,
   int unary;
   arith rc;

+  if (!op1)
+    return NULL;
+
   gfc_clear_ts (&temp.ts);

   switch (op)
@@ -1706,7 +1709,7 @@ eval_type_intrinsic0 (gfc_intrinsic_op iop, gfc_expr *op)
 static int
 gfc_zero_size_array (gfc_expr *e)
 {
-  if (e->expr_type != EXPR_ARRAY)
+  if (e == NULL || e->expr_type != EXPR_ARRAY)
     return 0;

   return e->value.constructor == NULL;

[Bug fortran/104210] [11/12 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685 since r11-1814-gcc9a9229285a26ac

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2022-March/057722.html

[Bug fortran/104210] [11/12 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685 since r11-1814-gcc9a9229285a26ac

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:892c7f03ae63121766a8be48f7e3b672547fd627

commit r12-8003-g892c7f03ae63121766a8be48f7e3b672547fd627
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Mar 29 23:33:23 2022 +0200

    Fortran: improve error recovery for invalid coarray function declarations

    gcc/fortran/ChangeLog:

            PR fortran/104210
            * arith.cc (eval_intrinsic): Avoid NULL pointer dereference.
            (gfc_zero_size_array): Likewise.

    gcc/testsuite/ChangeLog:

            PR fortran/104210
            * gfortran.dg/pr104210.f90: New test.

[Bug fortran/104210] [11 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685 since r11-1814-gcc9a9229285a26ac

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12 Regression] ICE in   |[11 Regression] ICE in
                   |gfc_zero_size_array, at     |gfc_zero_size_array, at
                   |fortran/arith.cc:1685 since |fortran/arith.cc:1685 since
                   |r11-1814-gcc9a9229285a26ac  |r11-1814-gcc9a9229285a26ac

--- Comment #5 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-12 so far.

[Bug fortran/104210] [11 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685 since r11-1814-gcc9a9229285a26ac

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:5de47ab9032b54a3ada986366168121f23a51c55

commit r11-9792-g5de47ab9032b54a3ada986366168121f23a51c55
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Mar 29 23:33:23 2022 +0200

    Fortran: improve error recovery for invalid coarray function declarations

    gcc/fortran/ChangeLog:

            PR fortran/104210
            * arith.c (eval_intrinsic): Avoid NULL pointer dereference.
            (gfc_zero_size_array): Likewise.

    gcc/testsuite/ChangeLog:

            PR fortran/104210
            * gfortran.dg/pr104210.f90: New test.

    (cherry picked from commit 892c7f03ae63121766a8be48f7e3b672547fd627)

[Bug fortran/104210] [11 Regression] ICE in gfc_zero_size_array, at fortran/arith.cc:1685 since r11-1814-gcc9a9229285a26ac

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104210

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from anlauf at gcc dot gnu.org ---
Fixed.