From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 7862B385380A; Tue, 25 Jan 2022 23:42:27 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7862B385380A
From: "fxcoudert at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/104233] [12 regression] ieee/issignaling_fallback.h
 broke Solaris/SPARC bootstrap
Date: Tue, 25 Jan 2022 23:42:27 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libfortran
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fxcoudert at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-104233-4-4LS8zSX4xI@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-104233-4@http.gcc.gnu.org/bugzilla/>
References: <bug-104233-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2022 23:42:27 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104233

--- Comment #4 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> =
---
> Shouldn't the __float128 stuff be guarded with
> defined(GFC_REAL_16_IS_FLOAT128) || defined(HAVE_GFC_REAL_17)

We could. My goal was for that header not to depend on libgfortran macros
(meaning it's generic), but GFC_REAL_16_IS_FLOAT128 would work in practice.

Re. HAVE_GFC_REAL_17 it is currently not supported in the IEEE files, so I'=
ll
avoid that for now.



Does that restore Solaris/SPARC bootstrap?

diff --git a/libgfortran/ieee/issignaling_fallback.h
b/libgfortran/ieee/issignaling_fallback.h
index 440a3f6c9a5..98b0b2819ac 100644
--- a/libgfortran/ieee/issignaling_fallback.h
+++ b/libgfortran/ieee/issignaling_fallback.h
@@ -195,9 +195,9 @@ __issignalingl (long double x)
 #endif


-#if __FLT128_IS_IEC_60559__
+#if defined(GFC_REAL_16_IS_FLOAT128)

-/* We have a _Float128 type.  */
+/* We have a __float128 type.  */

 typedef union
 {
@@ -234,7 +234,7 @@ __issignalingf128 (__float128 x)

 /* Define the type-generic macro based on the functions above.  */

-#if __FLT128_IS_IEC_60559__
+#if defined(GFC_REAL_16_IS_FLOAT128)
 # define issignaling(X) \
   _Generic ((X), \
            __float128: __issignalingf128, \=