public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "svante.signell at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug go/104290] [12 Regression] trunk 20220214 fails to build libgo on i686-gnu Date: Mon, 21 Feb 2022 16:05:03 +0000 [thread overview] Message-ID: <bug-104290-4-Ie4EQVdrLb@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104290-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104290 --- Comment #26 from Svante Signell <svante.signell at gmail dot com> --- (In reply to Ian Lance Taylor from comment #25) > > Hopefully someone knows hot to modify Makefile.tpl/Makefile.def to generate the correct dependencies in Makefile.in. > > I suggest that you open a separate bug for that, with a complete standalone > explanation of the problem. This bug is mixed in with a lot of other things. OK, will do. > > Another patch that is not applied: gcc_config_gnu.h.diff. Who will commit that patch? It is not directly relating to libgo, but gotools fails to build later on without it. > > I assume you mean this patch: > > https://gcc.gnu.org/bugzilla/attachment.cgi?id=52360&action=edit Yes! > I don't understand why that patch makes any difference. Where is the code > that checks OPTION_GLIBC? Pasted from Comment 1 and Comment 2: start paste__________ Additionally, continuing, the build of gotools fails: go1: error: '-fsplit-stack' currently only supported on GNU/Linux go1: error: '-fsplit-stack' is not supported by this compiler configuration The attached patch defines OPTION_GLIBC_P and OPTION_GLIBC that was lost for config/gnu.h, thus enabling split-stack support for GNU/Hurd again. This problem happened with the latest commit and fixes for #104170 and as discussed in the mail thread starting with https://gcc.gnu.org/pipermail/gcc-patches/2022-January/588973.html. end paste___________ The file first doing this check is: (first error: ..) src/gcc/common/config/i386/i386-common.cc in function: static bool ix86_supports_split_stack (bool report, struct gcc_options *opts ATTRIBUTE_UNUSED) and secondly in:src/gcc/opts.cc: (second error: ...) in function: void finish_options (struct gcc_options *opts, struct gcc_options *opts_set, location_t loc) The checking logic is in function ix86_supports_split_stack(): #if defined(TARGET_THREAD_SPLIT_STACK_OFFSET) && defined(OPTION_GLIBC_P) if (!OPTION_GLIBC_P (opts)) #endif { if (report) error ("%<-fsplit-stack%> currently only supported on GNU/Linux"); return false; } bool ret = true; In case of GNU/Hurd TARGET_THREAD_SPLIT_STACK_OFFSET is defined as well as OPTION_GLIBC_P but OPTION_GLIBC_P (opts) is needed to. The proposed patch to src/gcc/config/gnu.h creates that definition. Additionally, gnu.h is included in the configure stage: Configuring stage 1 in ./gcc ... Using the following target machine macro files: ... ../../src/gcc/config/gnu.h Thanks!
next prev parent reply other threads:[~2022-02-21 16:05 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-30 13:38 [Bug go/104290] New: [12 Regression] trunk 20220126 " doko at debian dot org 2022-01-31 8:21 ` [Bug go/104290] " rguenth at gcc dot gnu.org 2022-02-03 15:16 ` svante.signell at gmail dot com 2022-02-06 11:43 ` svante.signell at gmail dot com 2022-02-08 17:08 ` svante.signell at gmail dot com 2022-02-08 17:29 ` schwab@linux-m68k.org 2022-02-08 17:50 ` ian at airs dot com 2022-02-08 19:37 ` svante.signell at gmail dot com 2022-02-08 19:44 ` schwab@linux-m68k.org 2022-02-09 22:11 ` svante.signell at gmail dot com 2022-02-17 17:30 ` cvs-commit at gcc dot gnu.org 2022-02-17 22:20 ` svante.signell at gmail dot com 2022-02-17 22:21 ` svante.signell at gmail dot com 2022-02-17 22:22 ` svante.signell at gmail dot com 2022-02-17 22:23 ` svante.signell at gmail dot com 2022-02-17 22:23 ` svante.signell at gmail dot com 2022-02-17 22:24 ` svante.signell at gmail dot com 2022-02-17 22:25 ` svante.signell at gmail dot com 2022-02-17 22:25 ` svante.signell at gmail dot com 2022-02-17 22:26 ` svante.signell at gmail dot com 2022-02-17 22:41 ` svante.signell at gmail dot com 2022-02-17 22:45 ` svante.signell at gmail dot com 2022-02-18 18:28 ` ian at airs dot com 2022-02-18 22:57 ` ian at airs dot com 2022-02-18 23:33 ` [Bug go/104290] [12 Regression] trunk 20220214 " cvs-commit at gcc dot gnu.org 2022-02-19 9:40 ` svante.signell at gmail dot com 2022-02-20 20:15 ` ian at airs dot com 2022-02-21 16:05 ` svante.signell at gmail dot com [this message] 2022-02-21 16:23 ` ian at airs dot com 2022-05-06 8:32 ` [Bug go/104290] [12/13 " jakub at gcc dot gnu.org 2022-07-26 13:01 ` rguenth at gcc dot gnu.org 2022-07-29 6:31 ` pinskia at gcc dot gnu.org 2023-02-21 14:59 ` rguenth at gcc dot gnu.org 2023-02-21 17:00 ` ian at airs dot com 2023-03-15 16:27 ` svante.signell at gmail dot com 2023-05-08 12:23 ` [Bug go/104290] [12/13/14 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104290-4-Ie4EQVdrLb@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).