[Bug target/104298] New: [12 Regression] Broken cross compilers

[Bug target/104298] New: [12 Regression] Broken cross compilers

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104298

            Bug ID: 104298
           Summary: [12 Regression] Broken cross compilers
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org, raoni at linux dot ibm.com
  Target Milestone: ---
              Host: x86_64-linux-gnu
            Target: powerpc-xilinx-eabi, powerpc-eabisim

The mentioned 2 compilers are broken due to:

g++ -fcf-protection -fno-PIE -c   -g     -DIN_GCC -fPIC
-DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common 
-DHAVE_CONFIG_H -I. -I. -I/home/marxin/Programming/gcc/gcc
-I/home/marxin/Programming/gcc/gcc/.
-I/home/marxin/Programming/gcc/gcc/../include
-I/home/marxin/Programming/gcc/gcc/../libcpp/include
-I/home/marxin/Programming/gcc/gcc/../libcody 
-I/home/marxin/Programming/gcc/gcc/../libdecnumber
-I/home/marxin/Programming/gcc/gcc/../libdecnumber/dpd -I../libdecnumber
-I/home/marxin/Programming/gcc/gcc/../libbacktrace   -o insn-emit.o -MT
insn-emit.o -MMD -MP -MF ./.deps/insn-emit.TPo insn-emit.cc
/home/marxin/Programming/gcc/gcc/config/rs6000/rs6000.md: In function ‘rtx_def*
gen_fegetroundsi(rtx)’:
/home/marxin/Programming/gcc/gcc/config/rs6000/rs6000.md:6932:8: error:
‘OPTION_GLIBC’ was not declared in this scope
 6932 |   if (!OPTION_GLIBC)
      |        ^~~~~~~~~~~~
/home/marxin/Programming/gcc/gcc/config/rs6000/rs6000.md: In function ‘rtx_def*
gen_feclearexceptsi(rtx, rtx)’:
/home/marxin/Programming/gcc/gcc/config/rs6000/rs6000.md:6967:8: error:
‘OPTION_GLIBC’ was not declared in this scope
 6967 |   if (!OPTION_GLIBC)
      |        ^~~~~~~~~~~~
/home/marxin/Programming/gcc/gcc/config/rs6000/rs6000.md: In function ‘rtx_def*
gen_feraiseexceptsi(rtx, rtx)’:
/home/marxin/Programming/gcc/gcc/config/rs6000/rs6000.md:7007:8: error:
‘OPTION_GLIBC’ was not declared in this scope
 7007 |   if (!OPTION_GLIBC)
      |        ^~~~~~~~~~~~
make: *** [Makefile:1143: insn-emit.o] Error 1

[Bug target/104298] [12 Regression] Broken cross compilers

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104298

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-01-31
     Ever confirmed|0                           |1
   Target Milestone|---                         |12.0

[Bug target/104298] [12 Regression] Broken cross compilers

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104298

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52314
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52314&action=edit
gcc12-pr104298.patch

Perhaps we should fix this like this?
option-defaults.h should always go last...

[Bug target/104298] [12 Regression] Broken cross compilers

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104298

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2cbe5dd54f15e88e0b42567319aa9c8e7bad7946

commit r12-6948-g2cbe5dd54f15e88e0b42567319aa9c8e7bad7946
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Jan 31 20:08:18 2022 +0100

    rs6000: Fix up build of non-glibc/aix/darwin powerpc* targets [PR104298]

    As reported by Martin, while David has added OPTION_GLIBC define to aix
    and Iain to darwin, all the other non-linux targets now fail because
    rs6000.md macro isn't defined.

    One possibility is to define this macro in option-defaults.h which on
rs6000
    targets is included last, then we don't need to define it in aix/darwin
    headers and for targets using linux.h or linux64.h it will DTRT too.

    The other option is the first 2 hunks + changing the 3
       if (!OPTION_GLIBC)
         FAIL;
    cases in rs6000.md to e.g.
     #ifdef OPTION_GLIBC
       if (!OPTION_GLIBC)
     #endif
         FAIL;
    or to:
     #ifdef OPTION_GLIBC
       if (!OPTION_GLIBC)
     #else
       if (true)
     #endif
         FAIL;
    (the latter case if Richi wants to push the -Wunreachable-code changes for
    GCC 13).

    2022-01-31  Jakub Jelinek  <jakub@redhat.com>

            PR target/104298
            * config/rs6000/aix.h (OPTION_GLIBC): Remove.
            * config/rs6000/darwin.h (OPTION_GLIBC): Likewise.
            * config/rs6000/option-defaults.h (OPTION_GLIBC): Define to 0
            if not already defined.

[Bug target/104298] [12 Regression] Broken cross compilers

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104298

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed I guess.