[Bug analyzer/104308] no location info provided for [-Wanalyzer-use-of-uninitialized-value] warnings

["cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104308

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:a5dc2641add6b4f54086d40ae706fda3cdaac7f5

commit r12-8253-ga5dc2641add6b4f54086d40ae706fda3cdaac7f5
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Mon Apr 25 19:34:33 2022 -0400

    gimple-fold: fix further missing stmt locations [PR104308]

    PR analyzer/104308 initially reported about a
    -Wanalyzer-use-of-uninitialized-value diagnostic using UNKNOWN_LOCATION
    when complaining about certain memmove operations where the source
    is uninitialized.

    In r12-7856-g875342766d4298 I fixed the missing location for
    a stmt generated by gimple_fold_builtin_memory_op, but the reporter
    then found another way to generate such a stmt with UNKNOWN_LOCATION.

    I've now gone through gimple_fold_builtin_memory_op looking at all
    statement creation, and found three places in which a new statement
    doesn't have a location set on it (either directly via
    gimple_set_location, or indirectly via gsi_replace), one of which is
    the new reproducer.

    This patch adds a gimple_set_location to these three cases, and adds
    test coverage for one of them (the third hunk within the patch), fixing
    the new reproducer for PR analyzer/104308.

    gcc/ChangeLog:
            PR analyzer/104308
            * gimple-fold.cc (gimple_fold_builtin_memory_op): Explicitly set
            the location of new_stmt in all places that don't already set it,
            whether explicitly, or via a call to gsi_replace.

    gcc/testsuite/ChangeLog:
            PR analyzer/104308
            * gcc.dg/analyzer/pr104308.c: Add test coverage.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>