[Bug fortran/104311] New: [9/10/11/12 Regression] ICE out of memory

[Bug fortran/104311] New: [9/10/11/12 Regression] ICE out of memory

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

            Bug ID: 104311
           Summary: [9/10/11/12 Regression] ICE out of memory
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to r8, changed between 20190208 and 20190308 :
(follow-up of pr104227)


$ cat z1.f90
program p
   type t
   end type
   type(t) :: x(2)
   x = transfer(1, x, huge(1))
end


$ gfortran-7 -c z1.f90
z1.f90:5:3:

    x = transfer(1, x, huge(1))
   1
Error: Different shape for array assignment at (1) on dimension 1 (2 and
2147483647)


$ gfortran-12-20220130 -c z1.f90
GNU MP: Cannot allocate memory (size=8)
f951: out of memory allocating 139 bytes after a total of 1499426816 bytes

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-pc-linux-gnu
           Keywords|                            |ice-on-invalid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

And for completeness :

$ cat z2.f90
program p
   type t
   end type
   type(t) :: x(2)
   print *, transfer(1, x, huge(1))
end

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-01-31
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
           Priority|P3                          |P4

--- Comment #2 from anlauf at gcc dot gnu.org ---
We could limit the size of the resulting array constructor, using e.g.
flag_max_array_constructor.

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.5

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r10-653-g6c7ae8c56f9341f1

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11/12 Regression] ICE |[9/10/11/12 Regression] ICE
                   |out of memory               |out of memory since
                   |                            |r10-653-g6c7ae8c56f9341f1
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r10-653-g6c7ae8c56f9341f1.

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
            Summary|[9/10/11/12 Regression] ICE |[9/10/11/12 Regression] ICE
                   |out of memory since         |out of memory since
                   |r10-653-g6c7ae8c56f9341f1   |r9-6321-g4716603bf875ce

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
That is weird bisection, how could an OpenMP only change affect something that
isn't OpenMP related?
My bisection points to r9-6321-g4716603bf875ce
which has been backported to 8 in r8-9135-g8eecc0e4229c51b51.

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #4)
> That is weird bisection, how could an OpenMP only change affect something
> that isn't OpenMP related?
> My bisection points to r9-6321-g4716603bf875ce
> which has been backported to 8 in r8-9135-g8eecc0e4229c51b51.

Well, tested with ulimit -v xyz ;)

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

--- Comment #6 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #2)
> We could limit the size of the resulting array constructor, using e.g.
> flag_max_array_constructor.

Sample patch:

diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index 6483f9c31e7..15a2b36eed9 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -8152,6 +8152,15 @@ gfc_simplify_transfer (gfc_expr *source, gfc_expr *mold,
gfc_expr *size)
   if (source->expr_type == EXPR_ARRAY && !gfc_array_size (source, &tmp))
     gfc_internal_error ("Failure getting length of a constant array.");

+  if (size && mpz_cmp_si (size->value.integer, flag_max_array_constructor) >
0)
+    {
+      gfc_error ("The number of elements in the array constructor "
+                "at %L requires an increase of the allowed %d "
+                "upper limit.   See %<-fmax-array-constructor%> "
+                "option", &size->where, flag_max_array_constructor);
+      return NULL;
+    }
+
   /* Create an empty new expression with the appropriate characteristics.  */
   result = gfc_get_constant_expr (mold->ts.type, mold->ts.kind,
                                  &source->where);

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

--- Comment #7 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #6)
> (In reply to anlauf from comment #2)
> > We could limit the size of the resulting array constructor, using e.g.
> > flag_max_array_constructor.
> 
> Sample patch:

Well, thinking some more and rereading the standard text, I see I got it wrong.
A comment in gfc_calculate_transfer_sizes explains what it should be.
So the right thing is simply:

diff --git a/gcc/fortran/check.cc b/gcc/fortran/check.cc
index d6c6767ae9e..fc97bb1371e 100644
--- a/gcc/fortran/check.cc
+++ b/gcc/fortran/check.cc
@@ -6150,7 +6150,7 @@ gfc_calculate_transfer_sizes (gfc_expr *source, gfc_expr
*mold, gfc_expr *size,
    * representation is not shorter than that of SOURCE.
    * If SIZE is present, the result is an array of rank one and size SIZE.
    */
-  if (result_elt_size == 0 && *source_size > 0 && !size
+  if (result_elt_size == 0 && *source_size > 0
       && (mold->expr_type == EXPR_ARRAY || mold->rank))
     {
       gfc_error ("%<MOLD%> argument of %<TRANSFER%> intrinsic at %L is an "

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #8 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2022-February/057499.html

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:4e4252db0348a7274663a892c3a96d3ed7702aff

commit r12-7032-g4e4252db0348a7274663a892c3a96d3ed7702aff
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Feb 1 23:33:24 2022 +0100

    Fortran: reject simplifying TRANSFER for MOLD with storage size 0

    gcc/fortran/ChangeLog:

            PR fortran/104311
            * check.cc (gfc_calculate_transfer_sizes): Checks for case when
            storage size of SOURCE is greater than zero while the storage size
            of MOLD is zero and MOLD is an array shall not depend on SIZE.

    gcc/testsuite/ChangeLog:

            PR fortran/104311
            * gfortran.dg/transfer_simplify_15.f90: New test.

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:7a0fab4bddce549380b2713a910127332a091e19

commit r11-9539-g7a0fab4bddce549380b2713a910127332a091e19
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Feb 1 23:33:24 2022 +0100

    Fortran: reject simplifying TRANSFER for MOLD with storage size 0

    gcc/fortran/ChangeLog:

            PR fortran/104311
            * check.c (gfc_calculate_transfer_sizes): Checks for case when
            storage size of SOURCE is greater than zero while the storage size
            of MOLD is zero and MOLD is an array shall not depend on SIZE.

    gcc/testsuite/ChangeLog:

            PR fortran/104311
            * gfortran.dg/transfer_simplify_15.f90: New test.

    (cherry picked from commit 4e4252db0348a7274663a892c3a96d3ed7702aff)

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:837ad03ad4a95629a0d17108f5258568bebbf13f

commit r10-10437-g837ad03ad4a95629a0d17108f5258568bebbf13f
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Feb 1 23:33:24 2022 +0100

    Fortran: reject simplifying TRANSFER for MOLD with storage size 0

    gcc/fortran/ChangeLog:

            PR fortran/104311
            * check.c (gfc_calculate_transfer_sizes): Checks for case when
            storage size of SOURCE is greater than zero while the storage size
            of MOLD is zero and MOLD is an array shall not depend on SIZE.

    gcc/testsuite/ChangeLog:

            PR fortran/104311
            * gfortran.dg/transfer_simplify_15.f90: New test.

    (cherry picked from commit 4e4252db0348a7274663a892c3a96d3ed7702aff)

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:2953e3d1b9b36b441f5a33d696760ed56742ee1e

commit r9-9939-g2953e3d1b9b36b441f5a33d696760ed56742ee1e
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Feb 1 23:33:24 2022 +0100

    Fortran: reject simplifying TRANSFER for MOLD with storage size 0

    gcc/fortran/ChangeLog:

            PR fortran/104311
            * check.c (gfc_calculate_transfer_sizes): Checks for case when
            storage size of SOURCE is greater than zero while the storage size
            of MOLD is zero and MOLD is an array shall not depend on SIZE.

    gcc/testsuite/ChangeLog:

            PR fortran/104311
            * gfortran.dg/transfer_simplify_15.f90: New test.

    (cherry picked from commit 4e4252db0348a7274663a892c3a96d3ed7702aff)

[Bug fortran/104311] [9/10/11/12 Regression] ICE out of memory since r9-6321-g4716603bf875ce

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104311

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from anlauf at gcc dot gnu.org ---
Fixed on all open branches.  Closing.

Thanks for the report!