public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/104321] Dead code since r12-4467-g64f9623765da33
Date: Tue, 01 Feb 2022 09:49:19 +0000	[thread overview]
Message-ID: <bug-104321-4-p8Yzdvm8kr@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104321-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104321

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
I think it is not only dead code but it should be also removed:

Glancing at the code, the 'data = NULL;' does not make sense (cf. 'memcpy(lhs,
rhs)' above, lhs is data+offset) – and also does not match the comment.
Besides, all testcases seem to be happy with that line being dead code

Thus, I think the following is the right solution:

diff --git a/gcc/fortran/trans-decl.cc b/gcc/fortran/trans-decl.cc
index 6493cc2f6b1..45ba440c1db 100644
--- a/gcc/fortran/trans-decl.cc
+++ b/gcc/fortran/trans-decl.cc
@@ -7107,5 +7107,2 @@ gfc_conv_cfi_to_gfc (stmtblock_t *init, stmtblock_t
*finally,
       /* if (cond) { block2 }  */
-      tmp = fold_build2_loc (input_location, MODIFY_EXPR, void_type_node,
-                            data, fold_convert (TREE_TYPE (data),
-                                                null_pointer_node));
       tmp = build3_v (COND_EXPR, cond_var, gfc_finish_block (&block2),

  parent reply	other threads:[~2022-02-01  9:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01  9:27 [Bug fortran/104321] New: " marxin at gcc dot gnu.org
2022-02-01  9:27 ` [Bug fortran/104321] " marxin at gcc dot gnu.org
2022-02-01  9:49 ` burnus at gcc dot gnu.org [this message]
2023-02-15 19:34 ` anlauf at gcc dot gnu.org
2023-03-25 19:04 ` cvs-commit at gcc dot gnu.org
2023-03-25 19:06 ` anlauf at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104321-4-p8Yzdvm8kr@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).