[Bug fortran/104328] New: ICE in resolve_omp_atomic, at fortran/openmp.cc:7760 (etc.)

[Bug fortran/104328] New: ICE in resolve_omp_atomic, at fortran/openmp.cc:7760 (etc.)

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104328

            Bug ID: 104328
           Summary: ICE in resolve_omp_atomic, at fortran/openmp.cc:7760
                    (etc.)
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20211128 and 20211205 :


$ cat z1.f90
program p
   integer :: k = 1
   !$omp atomic compare
   if ( k == 2 ) then
   end if
end


$ cat z2.f90
program p
   real :: x = 1
   !$omp atomic compare
   if ( x == 2 ) then
   end if
end


$ cat z3.f90
program p
   integer :: i
   !$omp atomic capture
   i = 1
   i = i + 1.
end


$ cat z4.f90
program p
   integer :: i = 0
   !$omp atomic capture
   i = i + 1.0
   i = i + 1.0
end


$ cat z5.f90
program p
   logical :: k = .true.
   !$omp atomic capture compare
   if ( k ) then
   else
   end if
end


$ gfortran-12-20220130 -c z1.f90 -fopenmp
f951: internal compiler error: Segmentation fault
0xcc655f crash_signal
        ../../gcc/toplev.cc:322
0x7385fa resolve_omp_atomic
        ../../gcc/fortran/openmp.cc:7760
0x76790b gfc_resolve_code(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.cc:12365
0x769407 resolve_codes
        ../../gcc/fortran/resolve.cc:17537
0x7694ce gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.cc:17572
0x7517f4 resolve_all_program_units
        ../../gcc/fortran/parse.cc:6586
0x7517f4 gfc_parse_file()
        ../../gcc/fortran/parse.cc:6842
0x79eecf gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:216

[Bug fortran/104328] [12 Regression] ICE in resolve_omp_atomic, at fortran/openmp.cc:7760 (etc.) since r12-5793-g689407ef916503b2

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104328

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |burnus at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-02-02
            Summary|ICE in resolve_omp_atomic,  |[12 Regression] ICE in
                   |at fortran/openmp.cc:7760   |resolve_omp_atomic, at
                   |(etc.)                      |fortran/openmp.cc:7760
                   |                            |(etc.) since
                   |                            |r12-5793-g689407ef916503b2

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-5793-g689407ef916503b2.

[Bug fortran/104328] [12 Regression] ICE in resolve_omp_atomic, at fortran/openmp.cc:7760 (etc.) since r12-5793-g689407ef916503b2

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104328

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The first 2 testcases can be fixed with
--- openmp.cc.jj2       2022-01-21 11:01:12.458449420 +0100
+++ openmp.cc   2022-02-02 16:21:36.813563894 +0100
@@ -7757,6 +7757,7 @@ resolve_omp_atomic (gfc_code *code)
       if (code->op == EXEC_IF
          && code->block
          && code->block->op == EXEC_IF
+         && code->block->next
          && code->block->next->op == EXEC_ASSIGN)
        {
          comp_cond = code->block->expr1;
The last 3 need other fixes.

[Bug fortran/104328] [12 Regression] ICE in resolve_omp_atomic, at fortran/openmp.cc:7760 (etc.) since r12-5793-g689407ef916503b2

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104328

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
   Target Milestone|---                         |12.0
                 CC|                            |jakub at gcc dot gnu.org
           Priority|P3                          |P4

[Bug fortran/104328] [12 Regression] ICE in resolve_omp_atomic, at fortran/openmp.cc:7760 (etc.) since r12-5793-g689407ef916503b2

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104328

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52332
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52332&action=edit
gcc12-pr104328.patch

Untested fix.

[Bug fortran/104328] [12 Regression] ICE in resolve_omp_atomic, at fortran/openmp.cc:7760 (etc.) since r12-5793-g689407ef916503b2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104328

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:54d21dd5b5c5c5539505b3e037cdecb3b0ab3918

commit r12-7011-g54d21dd5b5c5c5539505b3e037cdecb3b0ab3918
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Feb 3 09:01:07 2022 +0100

    openmp, fortran: Improve !$omp atomic checks [PR104328]

    The testcase shows some cases that weren't verified and we ICE on
    invalid because of that.
    One problem is that unlike before, we weren't checking if some expression
    is EXPR_VARIABLE with non-NULL symtree in the case where there was
    a conversion around it.
    The other two issues is that we check that in an IF ->block is non-NULL
    and then immediately dereference ->block->next->op, but on invalid
    code with no statements in the then clause ->block->next might be NULL.

    2022-02-02  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/104328
            * openmp.cc (is_scalar_intrinsic_expr): If must_be_var && conv_ok
            and expr is conversion, verify it is a conversion from
EXPR_VARIABLE
            with non-NULL symtree.  Check ->block->next before dereferencing
it.

            * gfortran.dg/gomp/atomic-27.f90: New test.

[Bug fortran/104328] [12 Regression] ICE in resolve_omp_atomic, at fortran/openmp.cc:7760 (etc.) since r12-5793-g689407ef916503b2

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104328

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed, thanks for the report.