From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 0FE763858408; Thu,  3 Feb 2022 08:05:14 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0FE763858408
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/104328] [12 Regression] ICE in resolve_omp_atomic, at
 fortran/openmp.cc:7760 (etc.) since r12-5793-g689407ef916503b2
Date: Thu, 03 Feb 2022 08:05:12 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: openmp
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-104328-4-mzCQuGCmrs@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-104328-4@http.gcc.gnu.org/bugzilla/>
References: <bug-104328-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2022 08:05:14 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104328

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:54d21dd5b5c5c5539505b3e037cdecb3b0ab3918

commit r12-7011-g54d21dd5b5c5c5539505b3e037cdecb3b0ab3918
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Feb 3 09:01:07 2022 +0100

    openmp, fortran: Improve !$omp atomic checks [PR104328]

    The testcase shows some cases that weren't verified and we ICE on
    invalid because of that.
    One problem is that unlike before, we weren't checking if some expressi=
on
    is EXPR_VARIABLE with non-NULL symtree in the case where there was
    a conversion around it.
    The other two issues is that we check that in an IF ->block is non-NULL
    and then immediately dereference ->block->next->op, but on invalid
    code with no statements in the then clause ->block->next might be NULL.

    2022-02-02  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/104328
            * openmp.cc (is_scalar_intrinsic_expr): If must_be_var && conv_=
ok
            and expr is conversion, verify it is a conversion from
EXPR_VARIABLE
            with non-NULL symtree.  Check ->block->next before dereferencing
it.

            * gfortran.dg/gomp/atomic-27.f90: New test.=