[Bug fortran/104331] New: [10/11/12 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[Bug fortran/104331] New: [10/11/12 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104331

            Bug ID: 104331
           Summary: [10/11/12 Regression] ICE in gfc_simplify_eoshift, at
                    fortran/simplify.cc:2590
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Starts with r10, changed between 20211031 and 20211107 :


$ cat z1.f90
program p
   character(3), parameter :: a(:) = ['123']
   character(3), parameter :: b(*) = eoshift(a, 1)
end


$ cat z2.f90
program p
   character(3), parameter :: a(:) = ['123']
   character(3), parameter :: b(2) = eoshift(a, 1)
end


$ cat z3.f90
program p
   character(3), parameter :: a(:) = ['123']
   character(3), parameter :: b(1,1) = eoshift(a, 1)
end


$ gfortran-12-20211031 -c z1.f90
z1.f90:2:34:

    2 |    character(3), parameter :: a(:) = ['123']
      |                                  1
Error: Parameter array 'a' at (1) cannot be automatic or of deferred shape


$ gfortran-12-20220130 -c z1.f90
f951: internal compiler error: Segmentation fault
0xcc655f crash_signal
        ../../gcc/toplev.cc:322
0x77ff73 gfc_simplify_eoshift(gfc_expr*, gfc_expr*, gfc_expr*, gfc_expr*)
        ../../gcc/fortran/simplify.cc:2590
0x70279e do_simplify
        ../../gcc/fortran/intrinsic.cc:4683
0x70d64a gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.cc:5055
0x7619c8 resolve_unknown_f
        ../../gcc/fortran/resolve.cc:2972
0x7619c8 resolve_function
        ../../gcc/fortran/resolve.cc:3329
0x7619c8 gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.cc:7169
0x6f2644 gfc_reduce_init_expr(gfc_expr*)
        ../../gcc/fortran/expr.cc:3155
0x6f55d0 gfc_match_init_expr(gfc_expr**)
        ../../gcc/fortran/expr.cc:3203
0x6df964 variable_decl
        ../../gcc/fortran/decl.cc:3004
0x6df964 gfc_match_data_decl()
        ../../gcc/fortran/decl.cc:6299
0x749f93 match_word
        ../../gcc/fortran/parse.cc:67
0x749f93 decode_statement
        ../../gcc/fortran/parse.cc:378
0x74b9da next_free
        ../../gcc/fortran/parse.cc:1397
0x74b9da next_statement
        ../../gcc/fortran/parse.cc:1629
0x74cf6b parse_spec
        ../../gcc/fortran/parse.cc:4168
0x7500bc parse_progunit
        ../../gcc/fortran/parse.cc:6192
0x751781 gfc_parse_file()
        ../../gcc/fortran/parse.cc:6737
0x79eecf gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:216

[Bug fortran/104331] [10/11/12 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104331

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-02-01
                 CC|                            |anlauf at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from anlauf at gcc dot gnu.org ---
Obvious fix, similar to other intrinsics:

diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index 8604162cfd5..6483f9c31e7 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -2572,6 +2572,9 @@ gfc_simplify_eoshift (gfc_expr *array, gfc_expr *shift,
gfc_expr *boundary,
   if (arraysize == 0)
     goto final;

+  if (array->shape == NULL)
+    goto final;
+
   arrayvec = XCNEWVEC (gfc_expr *, arraysize);
   array_ctor = gfc_constructor_first (array->value.constructor);
   for (i = 0; i < arraysize; i++)

[Bug fortran/104331] [10/11/12 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104331

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:447047a8f95c6bf4b1873f390c833e91aa8af18c

commit r12-6977-g447047a8f95c6bf4b1873f390c833e91aa8af18c
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Feb 1 21:36:42 2022 +0100

    Fortran: error recovery when simplifying EOSHIFT

    gcc/fortran/ChangeLog:

            PR fortran/104331
            * simplify.cc (gfc_simplify_eoshift): Avoid NULL pointer
            dereference when shape is not set.

    gcc/testsuite/ChangeLog:

            PR fortran/104331
            * gfortran.dg/eoshift_9.f90: New test.

[Bug fortran/104331] [10/11 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104331

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
   Target Milestone|---                         |10.4
            Summary|[10/11/12 Regression] ICE   |[10/11 Regression] ICE in
                   |in gfc_simplify_eoshift, at |gfc_simplify_eoshift, at
                   |fortran/simplify.cc:2590    |fortran/simplify.cc:2590

--- Comment #3 from anlauf at gcc dot gnu.org ---
Taking.

[Bug fortran/104331] [10/11 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104331

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug fortran/104331] [10/11 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104331

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:f4aa5a3e95ba106f3149157a0278616f7a5fd192

commit r11-9535-gf4aa5a3e95ba106f3149157a0278616f7a5fd192
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Feb 1 21:36:42 2022 +0100

    Fortran: error recovery when simplifying EOSHIFT

    gcc/fortran/ChangeLog:

            PR fortran/104331
            * simplify.c (gfc_simplify_eoshift): Avoid NULL pointer
            dereference when shape is not set.

    gcc/testsuite/ChangeLog:

            PR fortran/104331
            * gfortran.dg/eoshift_9.f90: New test.

    (cherry picked from commit 447047a8f95c6bf4b1873f390c833e91aa8af18c)

[Bug fortran/104331] [10/11 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104331

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:323e72a83d417b230c2d93455fa09a4b66614c2a

commit r10-10433-g323e72a83d417b230c2d93455fa09a4b66614c2a
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Feb 1 21:36:42 2022 +0100

    Fortran: error recovery when simplifying EOSHIFT

    gcc/fortran/ChangeLog:

            PR fortran/104331
            * simplify.c (gfc_simplify_eoshift): Avoid NULL pointer
            dereference when shape is not set.

    gcc/testsuite/ChangeLog:

            PR fortran/104331
            * gfortran.dg/eoshift_9.f90: New test.

    (cherry picked from commit 447047a8f95c6bf4b1873f390c833e91aa8af18c)

[Bug fortran/104331] [10/11 Regression] ICE in gfc_simplify_eoshift, at fortran/simplify.cc:2590

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104331

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from anlauf at gcc dot gnu.org ---
Fixed.