[Bug lto/104333] New: [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[Bug lto/104333] New: [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

            Bug ID: 104333
           Summary: [11/12 Regression] ICE with -flto
                    -Wl,-plugin-opt=debug
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
                CC: marxin at gcc dot gnu.org
  Target Milestone: ---

extern int printf (const char *, ...);
int foo (int arg) { return printf ("hello %d\n", arg); }
int main (int argc) { return foo (argc); }

./xgcc -B ./ -flto -Wl,-plugin-opt=debug rh2048551.c
ICEs
lto1: internal compiler error: in read_cgraph_and_symbols, at
lto/lto-common.cc:2740
0xab4035 read_cgraph_and_symbols(unsigned int, char const**)
        ../../gcc/lto/lto-common.cc:2740
0xa88d99 lto_main()
        ../../gcc/lto/lto.cc:625
in GCC 11 and 12, while it correctly complains:
xgcc: error: debug: No such file or directory
in GCC 10.
The reporter meant -Wl,-plugin-opt=-debug which works in all cases, but we
shouldn't ICE even on bad arguments.

[Bug lto/104333] [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
   Target Milestone|---                         |11.3

[Bug lto/104333] [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-02-02
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-6855-g4804de453e7f5f90. I can work on that.

[Bug lto/104333] [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
I think the proper fix is reversion of the commit.
What do you think Nathan?

[Bug lto/104333] [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
                 CC|                            |nathan at gcc dot gnu.org
           Assignee|marxin at gcc dot gnu.org          |unassigned at gcc dot gnu.org

[Bug lto/104333] [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Oh, the commit is needed in order to prevent:

g++ hello.cc -fmodules-ts -std=c++20 -x c++-system-header string_view
g++: error: string_view: No such file or directory

Let me prepare a patch.

[Bug lto/104333] [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:9a92e46c0e9a75cd14125493b8826d3e33dd0f67

commit r12-7002-g9a92e46c0e9a75cd14125493b8826d3e33dd0f67
Author: Martin Liska <mliska@suse.cz>
Date:   Wed Feb 2 14:21:51 2022 +0100

    lto: fix error handling for -Wl,-plugin-opt=debug

    When one uses something like: -Wl,-plugin-opt=debug,
    we end up with lto1 WPA invocation that has 'debug'
    on command line. We interpret that as input filename.

    The patch moves resolution checking later so that we end up with
    a reasonable error message:

    lto1: fatal error: open debug failed: No such file or directory
    compilation terminated.

            PR lto/104333

    gcc/lto/ChangeLog:

            * lto-common.cc (read_cgraph_and_symbols): Move resolution
            checking for number of files later and report a reasonable
            error message.
            * lto-object.cc (lto_obj_file_open): Make error fatal.

[Bug lto/104333] [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:fb812e0417adc20cac72986df3bf422ed007743c

commit r11-9533-gfb812e0417adc20cac72986df3bf422ed007743c
Author: Martin Liska <mliska@suse.cz>
Date:   Wed Feb 2 14:21:51 2022 +0100

    lto: fix error handling for -Wl,-plugin-opt=debug

    When one uses something like: -Wl,-plugin-opt=debug,
    we end up with lto1 WPA invocation that has 'debug'
    on command line. We interpret that as input filename.

    The patch moves resolution checking later so that we end up with
    a reasonable error message:

    lto1: fatal error: open debug failed: No such file or directory
    compilation terminated.

            PR lto/104333

    gcc/lto/ChangeLog:

            * lto-common.c (read_cgraph_and_symbols): Move resolution
            checking for number of files later and report a reasonable
            error message.
            * lto-object.c (lto_obj_file_open): Make error fatal.

    (cherry picked from commit 9a92e46c0e9a75cd14125493b8826d3e33dd0f67)

[Bug lto/104333] [11/12 Regression] ICE with -flto -Wl,-plugin-opt=debug

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104333

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.