From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 63C1F3858401; Wed, 26 Apr 2023 16:55:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63C1F3858401
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1682528131;
	bh=OHvRKPc+vg/jm/kZj0m7jMZZikf5n/tZ3CHeozppOEw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=jKzCW1R6a/W9l3wtWMeq9BqBsVfJ2uS0qYNWCihRzfMzHgCPffxIxWjTt304cc45c
	 vpjhpPoC/f715zdcQimlH2IQ31sEb0n5e4GREs8oDWi7lLjamur8JIHUWkzXAsMb4h
	 B5+KUtunFn/gpD4KBbNZ9ZN51+g2vNJKC7iaiWl4=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/104338] RISC-V: Subword atomics result in library calls
Date: Wed, 26 Apr 2023 16:55:31 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: patrick at rivosinc dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-104338-4-2pGr3TkeBw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-104338-4@http.gcc.gnu.org/bugzilla/>
References: <bug-104338-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104338

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick O'Neill <poneill@gcc.gnu.org>:

https://gcc.gnu.org/g:f797260adaf52bee0ec0e16190bbefbe1bfc3692

commit r14-269-gf797260adaf52bee0ec0e16190bbefbe1bfc3692
Author: Patrick O'Neill <patrick@rivosinc.com>
Date:   Tue Apr 18 14:33:13 2023 -0700

    RISCV: Inline subword atomic ops

    RISC-V has no support for subword atomic operations; code currently
    generates libatomic library calls.

    This patch changes the default behavior to inline subword atomic calls
    (using the same logic as the existing library call).
    Behavior can be specified using the -minline-atomics and
    -mno-inline-atomics command line flags.

    gcc/libgcc/config/riscv/atomic.c has the same logic implemented in asm.
    This will need to stay for backwards compatibility and the
    -mno-inline-atomics flag.

    2023-04-18 Patrick O'Neill <patrick@rivosinc.com>

    gcc/ChangeLog:
            PR target/104338
            * config/riscv/riscv-protos.h: Add helper function stubs.
            * config/riscv/riscv.cc: Add helper functions for subword maski=
ng.
            * config/riscv/riscv.opt: Add command-line flag.
            * config/riscv/sync.md: Add masking logic and inline asm for
fetch_and_op,
            fetch_and_nand, CAS, and exchange ops.
            * doc/invoke.texi: Add blurb regarding command-line flag.

    libgcc/ChangeLog:
            PR target/104338
            * config/riscv/atomic.c: Add reference to duplicate logic.

    gcc/testsuite/ChangeLog:
            PR target/104338
            * gcc.target/riscv/inline-atomics-1.c: New test.
            * gcc.target/riscv/inline-atomics-2.c: New test.
            * gcc.target/riscv/inline-atomics-3.c: New test.
            * gcc.target/riscv/inline-atomics-4.c: New test.
            * gcc.target/riscv/inline-atomics-5.c: New test.
            * gcc.target/riscv/inline-atomics-6.c: New test.
            * gcc.target/riscv/inline-atomics-7.c: New test.
            * gcc.target/riscv/inline-atomics-8.c: New test.

    Signed-off-by: Patrick O'Neill <patrick@rivosinc.com>
    Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>=