public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/104357] [Aarch64] Failure to use csinv instead of mvn+csel where possible Date: Wed, 02 Feb 2022 23:51:37 +0000 [thread overview] Message-ID: <bug-104357-4-BfKXcOEuIN@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104357-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104357 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Last reconfirmed| |2022-02-02 Component|target |tree-optimization Ever confirmed|0 |1 --- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> --- This will get GCC closer to what clang/LLVM produces: unsigned char stbi__clamp(int x) { int t = x; if ((unsigned)x > 255) { if (x < 0) t = 0; else if (x > 255) t = -1; } return t; } ---- CUT ---- The zero-extends are due to the cast not being outside of the csel and the RTL level is not really good at cross bb optimizations. The gimple level looks like: <bb 2> [local count: 1073741824]: x.0_1 = (unsigned int) x_3(D); if (x.0_1 > 255) goto <bb 3>; [50.00%] else goto <bb 4>; [50.00%] <bb 3> [local count: 536870913]: _7 = x_3(D) >= 0; _6 = (unsigned char) _7; _8 = -_6; goto <bb 5>; [100.00%] <bb 4> [local count: 536870913]: _4 = (unsigned char) x_3(D); <bb 5> [local count: 1073741824]: # _2 = PHI <_8(3), _4(4)> return _2; Which in theory could be improved to the what I gave above. The gimple level has no knowledge of the rtl/target level that to do - in unsigned, you need to a zero extend still.
next prev parent reply other threads:[~2022-02-02 23:51 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-02 23:40 [Bug target/104357] New: " gabravier at gmail dot com 2022-02-02 23:51 ` pinskia at gcc dot gnu.org [this message] 2022-02-03 0:02 ` [Bug tree-optimization/104357] " pinskia at gcc dot gnu.org 2022-02-03 0:05 ` [Bug tree-optimization/104357] " pinskia at gcc dot gnu.org 2023-05-04 5:37 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104357-4-BfKXcOEuIN@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).