public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/104375] [x86] Failure to recognize bzhi pattern when shr is present
Date: Wed, 18 May 2022 02:58:21 +0000	[thread overview]
Message-ID: <bug-104375-4-jQ4q9M3rpb@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104375-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104375

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:102237c9f2f2667eb73cb5473bd3a9a97296a414

commit r13-581-g102237c9f2f2667eb73cb5473bd3a9a97296a414
Author: liuhongt <hongtao.liu@intel.com>
Date:   Thu Apr 28 15:30:06 2022 +0800

    recognize bzhi pattern when there's zero_extendsidi.

    backend has

    16550(define_insn "*bmi2_bzhi_<mode>3_2"
    16551  [(set (match_operand:SWI48 0 "register_operand" "=r")
    16552        (and:SWI48
    16553          (plus:SWI48
    16554            (ashift:SWI48 (const_int 1)
    16555                          (match_operand:QI 2 "register_operand" "r"))
    16556            (const_int -1))
    16557          (match_operand:SWI48 1 "nonimmediate_operand" "rm")))
    16558   (clobber (reg:CC FLAGS_REG))]
    16559  "TARGET_BMI2"
    16560  "bzhi\t{%<k>2, %1, %0|%0, %1, %<k>2}"
    16561  [(set_attr "type" "bitmanip")
    16562   (set_attr "prefix" "vex")
    16563   (set_attr "mode" "<MODE>")])

    But there's extra zero_extend in pattern match.

    424Failed to match this instruction:
    425(parallel [
    426        (set (reg:DI 90)
    427            (zero_extend:DI (and:SI (plus:SI (ashift:SI (const_int 1
[0x1])
    428                            (subreg:QI (reg:SI 98) 0))
    429                        (const_int -1 [0xffffffffffffffff]))
    430                    (subreg:SI (reg:DI 95) 0))))
    431        (clobber (reg:CC 17 flags))
    432    ])

    Add new define_insn for it.

    gcc/ChangeLog:

            PR target/104375
            * config/i386/i386.md (*bmi2_bzhi_zero_extendsidi_4): New
            define_insn.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr104375.c: New test.

  parent reply	other threads:[~2022-05-18  2:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-03 23:17 [Bug target/104375] New: [x86] Failure to recognize bzhi patter nwhen " gabravier at gmail dot com
2022-02-04  0:00 ` [Bug target/104375] [x86] Failure to recognize bzhi pattern when " pinskia at gcc dot gnu.org
2022-04-28  7:09 ` crazylht at gmail dot com
2022-05-18  2:58 ` cvs-commit at gcc dot gnu.org [this message]
2022-05-18  2:59 ` crazylht at gmail dot com
2023-02-18 13:58 ` gabravier at gmail dot com
2023-02-18 17:08 ` ubizjak at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104375-4-jQ4q9M3rpb@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).