public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug debug/104407] [10/11/12 Regression] '-fcompare-debug' failure (length) w/ -std=c++17 -O1 Date: Wed, 09 Feb 2022 14:19:18 +0000 [thread overview] Message-ID: <bug-104407-4-KHU82clWrK@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104407-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104407 --- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:be9cd0ca8a5f13cfee6a39b217d439a25c53553a commit r12-7129-gbe9cd0ca8a5f13cfee6a39b217d439a25c53553a Author: Jakub Jelinek <jakub@redhat.com> Date: Wed Feb 9 15:17:52 2022 +0100 dwarf2out: Don't call expand_expr during early_dwarf [PR104407] As mentioned in the PR, since PR96690 r11-2834 we call rtl_for_decl_init which can call expand_expr already during early_dwarf. The comment and PR explains it that the intent is to ensure the referenced vars and functions are properly mangled because free_lang_data doesn't cover everything, like template parameters etc. It doesn't work well though, because expand_expr can set DECL_RTLs e.g. on referenced vars and keep them there, and they can be created e.g. with different MEM_ALIGN compared to what they would be created with if they were emitted later. So, the following patch stops calling rtl_for_decl_init and instead for cases for which rtl_for_decl_init does anything at all walks the initializer and ensures referenced vars or functions are mangled. 2022-02-09 Jakub Jelinek <jakub@redhat.com> PR debug/104407 * dwarf2out.cc (mangle_referenced_decls): New function. (tree_add_const_value_attribute): Don't call rtl_for_decl_init if early_dwarf. Instead walk the initializer and try to mangle vars or functions referenced from it. * g++.dg/debug/dwarf2/pr104407.C: New test.
next prev parent reply other threads:[~2022-02-09 14:19 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-06 7:32 [Bug debug/104407] New: " asolokha at gmx dot com 2022-02-06 8:51 ` [Bug debug/104407] " pinskia at gcc dot gnu.org 2022-02-06 8:52 ` [Bug target/104407] " pinskia at gcc dot gnu.org 2022-02-07 9:05 ` jakub at gcc dot gnu.org 2022-02-07 9:17 ` jakub at gcc dot gnu.org 2022-02-07 9:19 ` jakub at gcc dot gnu.org 2022-02-07 9:23 ` jakub at gcc dot gnu.org 2022-02-07 9:31 ` rguenth at gcc dot gnu.org 2022-02-07 9:38 ` jakub at gcc dot gnu.org 2022-02-07 9:42 ` jakub at gcc dot gnu.org 2022-02-07 9:42 ` rguenth at gcc dot gnu.org 2022-02-07 9:44 ` rguenth at gcc dot gnu.org 2022-02-07 9:50 ` [Bug debug/104407] " jakub at gcc dot gnu.org 2022-02-07 10:50 ` rguenth at gcc dot gnu.org 2022-02-07 11:10 ` jakub at gcc dot gnu.org 2022-02-07 11:22 ` rguenther at suse dot de 2022-02-07 11:35 ` jakub at gcc dot gnu.org 2022-02-09 14:19 ` cvs-commit at gcc dot gnu.org [this message] 2022-02-09 14:19 ` [Bug debug/104407] [10/11 " jakub at gcc dot gnu.org 2022-06-28 10:48 ` jakub at gcc dot gnu.org 2023-07-07 10:42 ` [Bug debug/104407] [11 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104407-4-KHU82clWrK@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).