public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tschwinge at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/104423] [libgomp, testsuite] Add means to do accelerator-only testing in libgomp
Date: Tue, 08 Feb 2022 14:15:25 +0000	[thread overview]
Message-ID: <bug-104423-4-PGdQFST5uG@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104423-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104423

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tschwinge at gcc dot gnu.org
     Ever confirmed|0                           |1
           Keywords|                            |openacc, openmp
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-02-08
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=66005

--- Comment #2 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> I noticed that a lot of time is spent running libgomp tests that do not use the accelerator, and which are not needed for my purposes.

We can assume that effectively all OpenACC test cases use any available GPUs.

For OpenMP test cases indeed there is no clear answer.

> It would be nice if libgomp provided a mode to run only tests that use the accelerator, to drive down the test-board.sh execution time.

We may add a knob to skip the OpenACC '-foffload=disable' testing.

For OpenMP test cases, we'd either have to manually mark them up (error prone
and generally ugly), or scan the source file(s) (error prone and generally
ugly), or use some kind of marker that gets set during compilation if any
offloading code has been generated.

Regarding the latter, you also reported:

(In reply to Tom de Vries from comment #1)
> Looking at f.i. test-case for-3.c, compilation takes 3 minutes

We should be able to at least mitigate that problem via my PR66005 idea.

> and execution a few seconds.  It would make sense to reuse the executable.

I suppose you mean re-use across what currently are independent libgomp
testsuite invocations:

(In reply to Tom de Vries from comment #1)
> One of the dimensions that I test is env var GOMP_NVPTX_JIT, with values:
> - -O0, and
> - default (using unset GOMP_NVPTX_JIT), which supposedly is -O4.

For OpenACC, we'd hook that into the existing looping over any available GPUs
(plus host fallback).

For OpenMP, there currently is no such looping.

If paralellizing compilation via PR66005 is not sufficient then indeed we have
to think about switching OpenACC testing to a mode where only once we do
compile (without any '-foffload=[...]), and then loop over 'ACC_DEVICE_TYPE'
etc.

  parent reply	other threads:[~2022-02-08 14:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 15:43 [Bug testsuite/104423] New: " vries at gcc dot gnu.org
2022-02-08 12:32 ` [Bug testsuite/104423] " vries at gcc dot gnu.org
2022-02-08 14:15 ` tschwinge at gcc dot gnu.org [this message]
2022-02-08 14:47 ` vries at gcc dot gnu.org
2022-02-11 14:59 ` vries at gcc dot gnu.org
2022-02-14 16:14 ` vries at gcc dot gnu.org
2022-05-29  5:11 ` egallager at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104423-4-PGdQFST5uG@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).