public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/104459] [9/10/11/12 Regression] '-fcompare-debug' failure w/ -O2 -funswitch-loops -fno-tree-dce Date: Wed, 09 Feb 2022 19:07:13 +0000 [thread overview] Message-ID: <bug-104459-4-L3V0q6PuJX@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104459-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104459 --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> --- On the other side, df-scan.cc does in 3 other spots: /* By adding the ref directly, df_insn_rescan my not find any differences even though the block will have changed. So we need to mark the block dirty ourselves. */ if (!DEBUG_INSN_P (DF_REF_INSN (ref))) df_set_bb_dirty (bb); and /* The block must be marked as dirty now, rather than later as in df_insn_rescan and df_notes_rescan because it may not be there at rescanning time and the mark would blow up. DEBUG_INSNs do not make a block's data flow solution dirty (at worst the LUIDs are no longer contiguous). */ if (bb != NULL && NONDEBUG_INSN_P (insn)) df_set_bb_dirty (bb); and if (!DEBUG_INSN_P (insn)) df_set_bb_dirty (bb); so I wonder if another fix wouldn't be just not call df_set_bb_dirty on DEBUG_INSN_P in df_insn_change_bb. But what do I know about df :(.
next prev parent reply other threads:[~2022-02-09 19:07 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-09 11:43 [Bug debug/104459] New: " asolokha at gmx dot com 2022-02-09 12:03 ` [Bug rtl-optimization/104459] " rguenth at gcc dot gnu.org 2022-02-09 18:56 ` jakub at gcc dot gnu.org 2022-02-09 19:07 ` jakub at gcc dot gnu.org [this message] 2022-02-09 19:13 ` jakub at gcc dot gnu.org 2022-02-11 10:24 ` cvs-commit at gcc dot gnu.org 2022-02-11 11:00 ` [Bug rtl-optimization/104459] [9/10/11 " jakub at gcc dot gnu.org 2022-05-27 9:47 ` [Bug rtl-optimization/104459] [10/11 " rguenth at gcc dot gnu.org 2022-06-28 10:48 ` jakub at gcc dot gnu.org 2023-07-07 10:42 ` [Bug rtl-optimization/104459] [11 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104459-4-L3V0q6PuJX@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).