public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "amacleod at redhat dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/104475] [12 Regression] Wstringop-overflow + atomics incorrect warning on dynamic object Date: Fri, 04 Mar 2022 14:47:29 +0000 [thread overview] Message-ID: <bug-104475-4-XJkmbHMKzC@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104475-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104475 --- Comment #6 from Andrew Macleod <amacleod at redhat dot com> --- Created attachment 52564 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52564&action=edit possible patch Perhaps better would be to not try to propagate NULL-ness. _1 = this_10(D)->d; _2 = &_1->m_mutex; if (_2 != 0B) goto <bb 5>; [90.00%] else goto <bb 3>; [10.00%] 2->5 (T) _1 : struct QFutureInterfaceBasePrivate * [1B, +INF] 2->5 (T) _2 : struct QMutex * [1B, +INF] 2->3 (F) _2 : struct QMutex * [0B, 0B] ON the edge 2->3 where _2 is 0, while it is also true that _1 must be 0, perhaps that doesn't buy us much? and may lead is down the UB path of differing expectations. We certainly would like to preserve knowing non-null, so instead of calling operator_addr_expr::fold_range, we could do the same actions, just not deal with the NULL side, thus sidestepping issues that arise with this whacky behaviour? So if the _2 is non-null, _1 is nonnull. OTherwie we claim to know nothing of _1.. The attached patch does just that, for what its owrth.
next prev parent reply other threads:[~2022-03-04 14:47 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-09 19:37 [Bug c++/104475] New: " thiago at kde dot org 2022-02-09 20:14 ` [Bug tree-optimization/104475] [12 Regression] " pinskia at gcc dot gnu.org 2022-02-09 23:48 ` msebor at gcc dot gnu.org 2022-02-16 14:56 ` jakub at gcc dot gnu.org 2022-03-03 14:00 ` aldyh at gcc dot gnu.org 2022-03-03 16:09 ` amacleod at redhat dot com 2022-03-03 17:55 ` amacleod at redhat dot com 2022-03-04 14:47 ` amacleod at redhat dot com [this message] 2022-03-09 13:13 ` rguenth at gcc dot gnu.org 2022-03-12 9:39 ` aldyh at gcc dot gnu.org 2022-03-23 12:47 ` rguenth at gcc dot gnu.org 2022-03-23 17:23 ` aldyh at gcc dot gnu.org 2022-05-06 8:32 ` [Bug tree-optimization/104475] [12/13 " jakub at gcc dot gnu.org 2022-07-26 12:59 ` rguenth at gcc dot gnu.org 2022-12-05 15:50 ` rguenth at gcc dot gnu.org 2022-12-05 16:36 ` thiago at kde dot org 2022-12-06 8:17 ` rguenth at gcc dot gnu.org 2022-12-06 9:11 ` rguenth at gcc dot gnu.org 2022-12-06 10:22 ` cvs-commit at gcc dot gnu.org 2022-12-06 10:26 ` rguenth at gcc dot gnu.org 2022-12-06 18:03 ` thiago at kde dot org 2022-12-07 9:46 ` rguenth at gcc dot gnu.org 2022-12-07 9:48 ` rguenth at gcc dot gnu.org 2022-12-07 9:49 ` rguenth at gcc dot gnu.org 2022-12-07 9:54 ` rguenth at gcc dot gnu.org 2022-12-07 11:25 ` rguenth at gcc dot gnu.org 2023-01-17 17:37 ` jason at gcc dot gnu.org 2023-05-08 12:23 ` [Bug tree-optimization/104475] [12/13/14 " rguenth at gcc dot gnu.org 2023-09-18 9:19 ` aph at gcc dot gnu.org 2023-09-18 10:04 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104475-4-XJkmbHMKzC@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).