public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/104489] nvptx, sm_53: internal compiler error: in gen_rtx_SUBREG, at emit-rtl.cc:1022
Date: Mon, 04 Jul 2022 15:47:58 +0000	[thread overview]
Message-ID: <bug-104489-4-Ypbb8myO85@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104489-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104489

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:

https://gcc.gnu.org/g:ac4c8f53b0f735be17aa020796602de2299da1c5

commit r13-1462-gac4c8f53b0f735be17aa020796602de2299da1c5
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Mon Jul 4 16:45:47 2022 +0100

    middle-end: Support ABIs that pass FP values as wider integers.

    Sorry for the long delay getting back to this, but after deeper
    investigation, it turns out that Jeff Law's tingling spider senses
    that the original patch wasn't updating everywhere that was required
    were spot on.  Although my nvptx testing showed no problems with -O2,
    compiling the same tests with -O0 found several additional assertion
    ICEs (exactly where he'd predicted they'd be).

    Here's a revised patch that updates five locations (up from the
    previous two).  Finding any remaining locations (if any) might be
    easier once folks are able to test things on their targets.  This
    also implements Jeff's suggestion to factor the common code into
    helper routines.

    2022-07-04  Roger Sayle  <roger@nextmovesoftware.com>

    gcc/ChangeLog
            PR target/104489
            * calls.cc (precompute_register_parameters): Allow promotion
            of floating point values to be passed in wider integer modes
            by calling new convert_float_to_wider_int.
            (expand_call): Allow floating point results to be returned in
            wider integer modes by calling new convert wider_int_to_float.
            * cfgexpand.cc (expand_value_return): Allow backends to promote
            a scalar floating point return value to a wider integer mode
            by calling new convert_float_to_wider_int.
            * expr.cc (convert_float_to_wider_int): New function.
            (convert_wider_int_to_float): Likewise.
            (expand_expr_real_1) <expand_decl_rtl>: Allow backends to promote
            scalar FP PARM_DECLs to wider integer modes, by calling new
            convert_wider_int_to_float.
            * expr.h (convert_modes): Name arguments for improved
documentation.
            (convert_float_to_wider_int): Prototype new function here.
            (convert_wider_int_to_float): Likewise.
            * function.cc (assign_parm_setup_stack): Allow floating point
            values to be passed on the stack as wider integer modes by
            calling new convert_wider_int_to_float.

      parent reply	other threads:[~2022-07-04 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 15:05 [Bug target/104489] New: " vries at gcc dot gnu.org
2022-02-10 15:18 ` [Bug target/104489] " vries at gcc dot gnu.org
2022-02-11 10:15 ` vries at gcc dot gnu.org
2022-02-11 10:18 ` roger at nextmovesoftware dot com
2022-02-14  9:06 ` burnus at gcc dot gnu.org
2022-02-23  7:26 ` cvs-commit at gcc dot gnu.org
2022-07-04 15:47 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104489-4-Ypbb8myO85@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).