public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/104522] ICE: in real_to_decimal_for_mode with -O -fdump-tree-all-details and long double
Date: Mon, 14 Feb 2022 10:06:36 +0000	[thread overview]
Message-ID: <bug-104522-4-bcVhx3bbGC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104522-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104522

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |jsm28 at gcc dot gnu.org

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
So the issue is that native_interpret_real produces something that's not
printable.  For MODE_COMPOSITE_P types we have code that verifies
back-and-forth
conversion - when we enable that we get until RTL which happens to generate

(insn # 0 0 2 (set (reg:XF 8 st)
        (mem/u/c:XF (symbol_ref/u:DI ("*.LC1") [flags 0x2]) [  S16 A128]))
"t.c":9:6# {*movxf_internal}
     (expr_list:REG_EQUIV (const_double:XF

with "invalid" XFmode real again.  Here DSE1 does

 (note 3 0 2 2 [bb 2] NOTE_INSN_BASIC_BLOCK)
-(note 2 3 5 2 NOTE_INSN_FUNCTION_BEG)
-(insn 5 2 6 2 (set (reg:V8HI 51 xmm15)
-        (mem/u/c:V8HI (symbol_ref/u:DI ("*.LC0") [flags 0x2]) [0  S16 A128]))
"t.c":8:15 1694 {movv8hi_internal}
-     (expr_list:REG_EQUAL (const_vector:V8HI [
-                (const_int 512 [0x200])
-                (const_int 0 [0]) repeated x3
-                (const_int 16384 [0x4000])
-                (const_int 0 [0]) repeated x3
-            ])
-        (nil)))
-(insn 6 5 7 2 (set (mem/c:V8HI (plus:DI (reg/f:DI 19 frame)
-                (const_int -16 [0xfffffffffffffff0])) [2  S16 A128])
-        (reg:V8HI 51 xmm15)) "t.c":8:15 1694 {movv8hi_internal}
-     (expr_list:REG_DEAD (reg:V8HI 51 xmm15)
-        (nil)))
-(insn 7 6 8 2 (set (reg:XF 86 [ t1 ])
-        (mem/c:XF (symbol_ref:DI ("t1") [flags 0x2]  <var_decl 0x7ffff6526bd0
t1>) [1 t1+0 S16 A128])) "t.c":9:6 140 {*movxf_internal}
-     (nil))

to

+(note 2 3 13 2 NOTE_INSN_FUNCTION_BEG)
+(insn 13 2 7 2 (set (reg:XF 88)
+        (mem/u/c:XF (symbol_ref/u:DI ("*.LC1") [flags 0x2]) [0  S16 A128]))
"t.c":8:15 140 {*movxf_internal}
+     (expr_list:REG_EQUAL (const_double:XF

so the issue needs to be mitigated in multiple places.  Even if we sanitize
the FP value we'd need to fix the DSE side which invokes
native_decode_rtx which seems to also lack the COMPOSITE_MODE handling.

But I do wonder whether real_from_target needs fixing to handle invalid
input gracefully which is ultimatively decode_ieee_extended?

Any opinions here?

  parent reply	other threads:[~2022-02-14 10:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-13 19:09 [Bug rtl-optimization/104522] New: ICE: in real_to_decimal_for_mode, at real.cc:1770 with -O -fcompare-debug zsojka at seznam dot cz
2022-02-13 22:09 ` [Bug middle-end/104522] " pinskia at gcc dot gnu.org
2022-02-13 22:13 ` [Bug middle-end/104522] ICE: in real_to_decimal_for_mode with -O -fdump-tree-all-details and long double pinskia at gcc dot gnu.org
2022-02-14  9:43 ` rguenth at gcc dot gnu.org
2022-02-14 10:06 ` rguenth at gcc dot gnu.org [this message]
2022-02-14 11:08 ` ubizjak at gmail dot com
2022-02-14 11:51 ` rguenth at gcc dot gnu.org
2022-02-14 11:51 ` rguenth at gcc dot gnu.org
2022-02-14 13:20 ` jakub at gcc dot gnu.org
2022-02-14 14:27 ` rguenth at gcc dot gnu.org
2022-02-14 15:47 ` jakub at gcc dot gnu.org
2022-02-15 11:12 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104522-4-bcVhx3bbGC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).