public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/104539] Failed to inline a very simple template function when it's explicit instantiated. Date: Thu, 17 Feb 2022 22:51:14 +0000 [thread overview] Message-ID: <bug-104539-4-qLpvTQsArU@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-104539-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104539 --- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>: https://gcc.gnu.org/g:2c9b7077b72529fbbe896212a0088bff6025c5e7 commit r12-7288-g2c9b7077b72529fbbe896212a0088bff6025c5e7 Author: Jason Merrill <jason@redhat.com> Date: Thu Feb 17 00:04:21 2022 -0500 c++: inlining explicit instantiations [PR104539] The PR10968 fix cleared DECL_COMDAT to force output of explicit instantiations. Then the PR59469 fix added a call to mark_needed, after which we no longer need to clear DECL_COMDAT, and leaving it set allows us to inline explicit instantiations without worrying about symbol interposition. I suppose there's an argument to be made that an explicit instantiation declaration (extern template) should clear DECL_COMDAT, since that suggests that there will be only a single instantiation somewhere that could be subject to interposition, but that doesn't change the 'inline' semantics, and it seems cleaner to treat template instantiations uniformly. PR c++/104539 gcc/cp/ChangeLog: * pt.cc (mark_decl_instantiated): Don't clear DECL_COMDAT. gcc/testsuite/ChangeLog: * g++.dg/ipa/inline-4.C: New test.
next prev parent reply other threads:[~2022-02-17 22:51 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-15 4:34 [Bug tree-optimization/104539] New: " cassio.neri at gmail dot com 2022-02-15 4:35 ` [Bug tree-optimization/104539] " cassio.neri at gmail dot com 2022-02-15 8:13 ` [Bug c++/104539] " rguenth at gcc dot gnu.org 2022-02-17 5:11 ` jason at gcc dot gnu.org 2022-02-17 18:29 ` jason at gcc dot gnu.org 2022-02-17 22:51 ` cvs-commit at gcc dot gnu.org [this message] 2022-02-17 22:52 ` jason at gcc dot gnu.org 2024-03-18 7:08 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-104539-4-qLpvTQsArU@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).