From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 3512D3857C4F; Fri, 18 Feb 2022 06:53:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3512D3857C4F From: "rguenther at suse dot de" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/104550] bogus warning from -Wuninitialized + -ftrivial-auto-var-init=pattern Date: Fri, 18 Feb 2022 06:53:00 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: diagnostic X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenther at suse dot de X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: qinzhao at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2022 06:53:00 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104550 --- Comment #16 from rguenther at suse dot de --- On Thu, 17 Feb 2022, jakub at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104550 >=20 > --- Comment #15 from Jakub Jelinek --- > (In reply to qinzhao from comment #11) > > (In reply to Jakub Jelinek from comment #10) > > > Even in that case, filling the memory with pattern & mask instead of = filling > > > the memory with pattern + __builtin_clear_padding afterwards seems li= ke a > > > win. > >=20 > > So, you mean It's better to do the following for pattern init: > >=20 > > 1. add call to .DEFERRED_INIT(, pattern, ) during gimplification; > > 2. during RTL expansion, fill the memory with pattern & mask if the var= iable > > is in memory.=20 > >=20 > > how to implement "fill the memory with pattern & mask" during RTL expan= sion? > > currently, we use memset to fill the memory when the variable is in mem= ory, > > pattern & mask might not fit to a BYTE-repeatable pattern that can be u= sed > > for memset? >=20 > You can populate a buffer with the pattern and then clear_type_padding_in= _mask. > Then you can create a STRING_CST out from that array and store_expr > (the_STRING_CST, DECL_RTL (var), false, false, false) - at least when DEC= L_RTL > (var) is a MEM. It would of course be _highly_ desirable to _not_ need to build a STRING_CST here. The problematical cases are all when DECL_RTL isn't a MEM, of course.=