From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id B8F943858D3C; Wed, 16 Feb 2022 11:53:59 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B8F943858D3C
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/104558] [9/10/11/12 Regression] ICE: in
 expand_call, at calls.cc:3601 with -fabi-version=9 on pr83487.c
Date: Wed, 16 Feb 2022 11:53:59 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 9.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-104558-4-aY45x464S5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-104558-4@http.gcc.gnu.org/bugzilla/>
References: <bug-104558-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Feb 2022 11:53:59 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104558

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
It is the
-      emit_push_insn (arg->value, arg->mode, TREE_TYPE (pval), size_rtx,
-                     parm_align, partial, reg, excess, argblock,
-                     ARGS_SIZE_RTX (arg->locate.offset), reg_parm_stack_sp=
ace,
-                     ARGS_SIZE_RTX (arg->locate.alignment_pad), false);
+      if (!CONST_INT_P (size_rtx) || INTVAL (size_rtx) !=3D 0)
+       emit_push_insn (arg->value, arg->mode, TREE_TYPE (pval), size_rtx,
+                       parm_align, partial, reg, excess, argblock,
+                       ARGS_SIZE_RTX (arg->locate.offset),
+                       reg_parm_stack_space,
+                       ARGS_SIZE_RTX (arg->locate.alignment_pad), false);
change that breaks this.  While we don't really need to push anything when
size_rtx is const0_rtx, emit_push_insn at the end does:
  if (alignment_pad && args_addr =3D=3D 0)
    anti_adjust_stack (alignment_pad);
so I wonder if we don't need:
      else if (maybe_ne (arg->locate.alignment_pad, 0)
               && argblock =3D=3D NULL_RTX)
        anti_adjust_stack (ARGS_SIZE_RTX (arg->locate.alignment_pad));
or so (also in the other spot).=