public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/104559] vector<bool> v; v.insert(v.begin()); compiles, but it shouldn't
Date: Thu, 17 Feb 2022 23:45:00 +0000	[thread overview]
Message-ID: <bug-104559-4-QRK3QDxOl0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104559-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104559

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:12a88e6e208fa45a449775bfb9353c777a6081aa

commit r12-7289-g12a88e6e208fa45a449775bfb9353c777a6081aa
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Feb 17 17:37:42 2022 +0000

    libstdc++: Deprecate non-standard std::vector<bool>::insert(pos) [PR104559]

    The SGI STL and pre-1998 drafts of the C++ standard had a default
    argument for vector<bool>::insert(iterator, const bool&) which was
    remove by N1051. The default argument is still present in libstdc++ for
    some reason. There are no tests verifying it as an extension, so I don't
    think it has been kept intentionally.

    This removes the default argument but adds an overload without the
    second parameter, and adds the deprecated attribute to it. This allows
    any code using it to keep working (for now) but with a warning.

    libstdc++-v3/ChangeLog:

            PR libstdc++/104559
            * doc/xml/manual/evolution.xml: Document deprecation.
            * doc/html/manual/api.html: Regenerate.
            * include/bits/stl_bvector.h (insert(const_iterator, const bool&)):
            Remove default argument.
            (insert(const_iterator)): New overload with deprecated attribute.
            * testsuite/23_containers/vector/bool/modifiers/insert/104559.cc:
            New test.

  parent reply	other threads:[~2022-02-17 23:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 22:31 [Bug libstdc++/104559] New: " arthur.j.odwyer at gmail dot com
2022-02-15 22:50 ` [Bug libstdc++/104559] " pinskia at gcc dot gnu.org
2022-02-16  9:32 ` redi at gcc dot gnu.org
2022-02-16 10:01 ` de34 at live dot cn
2022-02-17 10:48 ` redi at gcc dot gnu.org
2022-02-17 23:45 ` cvs-commit at gcc dot gnu.org [this message]
2022-02-17 23:46 ` redi at gcc dot gnu.org
2022-02-17 23:46 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104559-4-QRK3QDxOl0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).