public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/104610] memcmp () == 0 can be optimized better for avx512f
Date: Mon, 30 Oct 2023 03:10:17 +0000	[thread overview]
Message-ID: <bug-104610-4-NjjEaRdtti@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104610-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104610

--- Comment #23 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:8c40b72036c967fbb1d1150515cf70aec382f0a2

commit r14-5002-g8c40b72036c967fbb1d1150515cf70aec382f0a2
Author: liuhongt <hongtao.liu@intel.com>
Date:   Mon Oct 9 15:07:54 2023 +0800

    Improve memcmpeq for 512-bit vector with vpcmpeq + kortest.

    When 2 vectors are equal, kmask is allones and kortest will set CF,
    else CF will be cleared.

    So CF bit can be used to check for the result of the comparison.

    Before:
            vmovdqu (%rsi), %ymm0
            vpxorq  (%rdi), %ymm0, %ymm0
            vptest  %ymm0, %ymm0
            jne     .L2
            vmovdqu 32(%rsi), %ymm0
            vpxorq  32(%rdi), %ymm0, %ymm0
            vptest  %ymm0, %ymm0
            je      .L5
    .L2:
            movl    $1, %eax
            xorl    $1, %eax
            vzeroupper
            ret

    After:
            vmovdqu64       (%rsi), %zmm0
            xorl    %eax, %eax
            vpcmpeqd        (%rdi), %zmm0, %k0
            kortestw        %k0, %k0
            setc    %al
            vzeroupper
            ret

    gcc/ChangeLog:

            PR target/104610
            * config/i386/i386-expand.cc (ix86_expand_branch): Handle
            512-bit vector with vpcmpeq + kortest.
            * config/i386/i386.md (cbranchxi4): New expander.
            * config/i386/sse.md: (cbranch<mode>4): Extend to V16SImode
            and V8DImode.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr104610-2.c: New test.

      parent reply	other threads:[~2023-10-30  3:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 11:00 [Bug target/104610] New: " pinskia at gcc dot gnu.org
2022-02-21 11:01 ` [Bug target/104610] " pinskia at gcc dot gnu.org
2022-02-22  4:03 ` crazylht at gmail dot com
2022-02-22  5:54 ` crazylht at gmail dot com
2022-02-22  5:55 ` crazylht at gmail dot com
2022-02-22  6:18 ` crazylht at gmail dot com
2022-02-22  6:32 ` crazylht at gmail dot com
2022-02-23  2:15 ` crazylht at gmail dot com
2022-02-23  6:18 ` crazylht at gmail dot com
2022-02-23 21:04 ` hjl.tools at gmail dot com
2022-02-24  5:33 ` crazylht at gmail dot com
2022-02-24  6:00 ` hjl.tools at gmail dot com
2022-02-26 20:26 ` hjl.tools at gmail dot com
2022-02-27 19:02 ` hjl.tools at gmail dot com
2022-02-27 19:29 ` hjl.tools at gmail dot com
2022-03-04  3:03 ` hjl.tools at gmail dot com
2022-03-28  5:05 ` crazylht at gmail dot com
2022-03-28  5:27 ` crazylht at gmail dot com
2022-05-18  2:47 ` cvs-commit at gcc dot gnu.org
2022-05-18  2:49 ` crazylht at gmail dot com
2022-06-16  7:41 ` crazylht at gmail dot com
2023-06-28 10:12 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:05 ` ubizjak at gmail dot com
2023-10-10  7:37 ` crazylht at gmail dot com
2023-10-30  3:10 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104610-4-NjjEaRdtti@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).