[Bug target/104618] New: [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu

[Bug target/104618] New: [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

            Bug ID: 104618
           Summary: [12 Regression] trunk 20220221 on x86_64-linux-gnu
                    ICEs building sh.cc for sh4-linux-gnu
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at debian dot org
  Target Milestone: ---

Created attachment 52484
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52484&action=edit
preprocessed source

seen with trunk 20220221, building a cross compiler on x86_64-linux-gnu:

../../src/gcc/config/sh/sh.cc: In function 'void output_stack_adjust(int, rtx,
int, HARD_REG_SET*, bool)':
../../src/gcc/config/sh/sh.cc:6813:40: internal compiler error: in
build_call_a, at cp/call.cc:381
 6813 |               insn = emit_fn (GEN_SUB3 (reg, reg, const_reg));
      |                                        ^

0x65712f build_call_a(tree_node*, int, tree_node**)
        ../../src/gcc/cp/call.cc:381
0x6a3d30 build_cxx_call(tree_node*, int, tree_node**, int, tree_node*)
        ../../src/gcc/cp/call.cc:10379
0x8752fc cp_build_function_call_vec(tree_node*, vec<tree_node*, va_gc,
vl_embed>**, int, tree_node*)
        ../../src/gcc/cp/typeck.cc:4285
0x83bf3e finish_call_expr(tree_node*, vec<tree_node*, va_gc, vl_embed>**, bool,
bool, int)
        ../../src/gcc/cp/semantics.cc:2895
0x7ca0fa cp_parser_postfix_expression
        ../../src/gcc/cp/parser.cc:7878
0x7b3b2a cp_parser_binary_expression
        ../../src/gcc/cp/parser.cc:10041
0x7b434e cp_parser_assignment_expression
        ../../src/gcc/cp/parser.cc:10345
0x7b7e37 cp_parser_parenthesized_expression_list_elt
        ../../src/gcc/cp/parser.cc:7986
0x7b7f80 cp_parser_parenthesized_expression_list
        ../../src/gcc/cp/parser.cc:8468
0x7ca016 cp_parser_postfix_expression
        ../../src/gcc/cp/parser.cc:7729
0x7b3b2a cp_parser_binary_expression
        ../../src/gcc/cp/parser.cc:10041
0x7b434e cp_parser_assignment_expression
        ../../src/gcc/cp/parser.cc:10345
0x7b5ea9 cp_parser_constant_expression
        ../../src/gcc/cp/parser.cc:10648
0x7b5f41 cp_parser_initializer_clause
        ../../src/gcc/cp/parser.cc:25216
0x7b4528 cp_parser_assignment_expression
        ../../src/gcc/cp/parser.cc:10365
0x7b5609 cp_parser_expression
        ../../src/gcc/cp/parser.cc:10515
0x7b8667 cp_parser_expression_statement
        ../../src/gcc/cp/parser.cc:12711
0x7c501a cp_parser_statement
        ../../src/gcc/cp/parser.cc:12507
0x7c610d cp_parser_statement_seq_opt
        ../../src/gcc/cp/parser.cc:12856
0x7c61bf cp_parser_compound_statement
        ../../src/gcc/cp/parser.cc:12808
Please submit a full bug report, with preprocessed source (by using
-freport-bug).

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
           Keywords|                            |build
          Component|target                      |c++

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This started between Feb 13 and today even.
Reducing ....

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-02-22
             Status|UNCONFIRMED                 |NEW
           Severity|normal                      |blocker

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced testcase:
extern void gen_addsi3 (void);
void output_stack_adjust ()
{
  (*(gen_addsi3)) ();
}
---- CUT ----


Note a workaround is to change the defines in sh.cc to be just:
#define GEN_MOV gen_movsi
#define GEN_ADD3 gen_addsi3
#define GEN_SUB3 gen_subsi3

Note this ICE only happens for C++14 and above.

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
                 CC|                            |jason at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:0096b0b467b2c98ed258f0ead9a8b87b2a6d8466

commit r12-7398-g0096b0b467b2c98ed258f0ead9a8b87b2a6d8466
Author: Jason Merrill <jason@redhat.com>
Date:   Fri Feb 25 15:26:17 2022 -0400

    c++: (*(fn))() [PR104618]

    The patch for PR90451 deferred marking to the point of actual use; we
missed
    this one because of the parens.

            PR c++/104618

    gcc/cp/ChangeLog:

            * typeck.cc (cp_build_addr_expr_1): Also
            maybe_undo_parenthesized_ref.

    gcc/testsuite/ChangeLog:

            * g++.dg/overload/paren1.C: New test.

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed?

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:03e0c807ef50684cc1d49144948aa409decb91f9

commit r12-7528-g03e0c807ef50684cc1d49144948aa409decb91f9
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Feb 28 12:05:34 2022 -0400

    c++: tweak to (*(fn))() patch [PR104618]

    Other callers of mark_single_function might also want to look through these
    wrapapers.

            PR c++/104618

    gcc/cp/ChangeLog:

            * decl2.cc (mark_single_function): Look through parens and location
            wrapper.
            * typeck.cc (cp_build_addr_expr_1): Not here.

[Bug c++/104618] [12 Regression] trunk 20220221 on x86_64-linux-gnu ICEs building sh.cc for sh4-linux-gnu (in build_call_a, at cp/call.cc:381)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104618

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Jason Merrill <jason at gcc dot gnu.org> ---
Should be fixed, yes.