From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 2AEAE3858C2C; Thu, 24 Mar 2022 13:29:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2AEAE3858C2C From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/104620] FAIL: g++.dg/cpp23/consteval-if2.C -std=gnu++20 (test for errors) Date: Thu, 24 Mar 2022 13:29:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c++ X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org X-Bugzilla-Target-Milestone: 12.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 13:29:29 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104620 Jakub Jelinek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jason at gcc dot gnu.org --- Comment #4 from Jakub Jelinek --- Another testcase to consider is: consteval int foo (int x) { return x; } consteval int bar () { return 2; } constexpr int baz (int x) { return x; } template constexpr int qux (int x) { int r =3D 0; if consteval // { dg-warning "'if consteval' only available with= " "" { target c++20_only } } { r +=3D 2 * bar (); } else { r +=3D foo (8 * baz (0)); } if ! consteval // { dg-warning "'if consteval' only available with= " "" { target c++20_only } } { r +=3D foo (32 * baz (0)); } if consteval // { dg-warning "'if consteval' only available with= " "" { target c++20_only } } { r +=3D 32 * bar (); } return r; } This one is valid, but before your r12-7264 was incorrectly rejected becaus= e 8 * baz (0) etc. is wrapped in NON_DEPENDENT_EXPR, potential_constant_expression_1 recursed on the NON_DEPENDENT_EXPR operand, found it is ok but cxx_eval_constant_expression rejected the NON_DEPENDENT_EXPR. Bet for the build_over_call processing_template_decl immediate_invocation_p code we need to punt silent= ly if there is something we can't handle but fail loudly if we can handle everything but it is clearly always not a constant expression.=20 potential_constant_expression_1 isn't 100% accurate, there are cases where = it gets stuff through.=