From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id DD70C3858C30; Sun,  9 Jul 2023 17:59:04 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD70C3858C30
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1688925544;
	bh=+xrdAKJce7/UIXEdZUPQqyzrUMdzNLzaf0DNIBV8Las=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=q/yurtbP4axrUuJB/mvIRaKmM5aTZk5stBdaUGNEt+DS5uPXeTLK/s73C6jVOz75L
	 vzIkLgyGyBMN6O/ak/C4BLJiJrzOARqoNMId5gbps+8AYWI6b+WQQxKn19j/nHUpej
	 intFmpv3QPI25toimz3tEc4D8Shza0CzMLFVUqFk=
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/104649] ICE in gfc_match_formal_arglist, at
 fortran/decl.cc:6733 since r6-1958-g4668d6f9c00d4767
Date: Sun, 09 Jul 2023 17:59:04 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pault at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-104649-4-09M2APgZD8@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-104649-4@http.gcc.gnu.org/bugzilla/>
References: <bug-104649-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104649

--- Comment #3 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to kargl from comment #2)
> Null pointer dereference.
>=20
>=20
> diff --git a/gcc/fortran/decl.cc b/gcc/fortran/decl.cc
> index bd586e75008..8e2cd511c4d 100644
> --- a/gcc/fortran/decl.cc
> +++ b/gcc/fortran/decl.cc
> @@ -6730,12 +6730,20 @@ ok:
>  	      || (p->next =3D=3D NULL && q->next !=3D NULL))
>  	    arg_count_mismatch =3D true;
>  	  else if ((p->sym =3D=3D NULL && q->sym =3D=3D NULL)
> -		    || strcmp (p->sym->name, q->sym->name) =3D=3D 0)
> +		    || (p->sym && q->sym
> +			&& strcmp (p->sym->name, q->sym->name) =3D=3D 0))
>  	    continue;
>  	  else
> -	    gfc_error_now ("Mismatch in MODULE PROCEDURE formal "
> -			   "argument names (%s/%s) at %C",
> -			   p->sym->name, q->sym->name);
> +	    {
> +	      if (q->sym)
> +		gfc_error_now ("Mismatch in MODULE PROCEDURE formal "
> +				"argument names (%qs/%qs) at %C",
> +				p->sym->name, q->sym->name);
> +	      else
> +		gfc_error_now ("Mismatch in MODULE PROCEDURE formal argument "
> +				"name, %qs, and alternate return at %C",
> +				p->sym->name);
> +	    }
>  	}
>=20=20
>        if (arg_count_mismatch)

The second testcase still segfaults and everything is so optimised away tha=
t I
cannot figure out why.

Paul=