public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf
@ 2022-02-23 8:55 doko at debian dot org
2022-02-23 10:38 ` [Bug gcov-profile/104656] " pinskia at gcc dot gnu.org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: doko at debian dot org @ 2022-02-23 8:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
Bug ID: 104656
Summary: [12 Regression] trunk 20220222 ftbfs for bpf
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: doko at debian dot org
Target Milestone: ---
trunk 20220222 fails to build for the bpf target:
../../../gcc-source/libgcc/libgcov-driver.c: In function ‘write_topn_counters’:
../../../gcc-source/libgcc/libgcov-driver.c:418:1: error: too many function
arguments for eBPF
418 | write_topn_counters (const struct gcov_ctr_info *ci_ptr,
| ^~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:928: _gcov_info_to_gcda.o] Error 1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug gcov-profile/104656] [12 Regression] trunk 20220222 ftbfs for bpf
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
@ 2022-02-23 10:38 ` pinskia at gcc dot gnu.org
2022-02-23 10:41 ` [Bug target/104656] " rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-02-23 10:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104656] [12 Regression] trunk 20220222 ftbfs for bpf
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
2022-02-23 10:38 ` [Bug gcov-profile/104656] " pinskia at gcc dot gnu.org
@ 2022-02-23 10:41 ` rguenth at gcc dot gnu.org
2022-02-23 11:04 ` doko at debian dot org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-02-23 10:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|gcov-profile |target
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I guess you need to use --disable-gcov when building BPF - maybe that can
somehow be done by default?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104656] [12 Regression] trunk 20220222 ftbfs for bpf
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
2022-02-23 10:38 ` [Bug gcov-profile/104656] " pinskia at gcc dot gnu.org
2022-02-23 10:41 ` [Bug target/104656] " rguenth at gcc dot gnu.org
@ 2022-02-23 11:04 ` doko at debian dot org
2022-02-23 11:09 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: doko at debian dot org @ 2022-02-23 11:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
--- Comment #2 from Matthias Klose <doko at debian dot org> ---
yes, adding that option lets the build succeed.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104656] [12 Regression] trunk 20220222 ftbfs for bpf
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
` (2 preceding siblings ...)
2022-02-23 11:04 ` doko at debian dot org
@ 2022-02-23 11:09 ` jakub at gcc dot gnu.org
2022-02-23 11:16 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-02-23 11:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The 5 words of arguments limitation in BPF is very severe, shouldn't the
backend do something smarter in that case and say pass in that case the
arguments but the first 4 words e.g. by invisible reference (push all the
remaining arguments to stack and pass address of the first such argument as a
pointer)?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104656] [12 Regression] trunk 20220222 ftbfs for bpf
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
` (3 preceding siblings ...)
2022-02-23 11:09 ` jakub at gcc dot gnu.org
@ 2022-02-23 11:16 ` pinskia at gcc dot gnu.org
2022-02-23 13:15 ` jose.marchesi at oracle dot com
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-02-23 11:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The ABI from the Linux kernel side needs to be documented that way.
So someone would need to propose that ABI change.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104656] [12 Regression] trunk 20220222 ftbfs for bpf
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
` (4 preceding siblings ...)
2022-02-23 11:16 ` pinskia at gcc dot gnu.org
@ 2022-02-23 13:15 ` jose.marchesi at oracle dot com
2022-02-24 15:44 ` cvs-commit at gcc dot gnu.org
2022-03-09 13:02 ` rguenth at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: jose.marchesi at oracle dot com @ 2022-02-23 13:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
Jose E. Marchesi <jose.marchesi at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jose.marchesi at oracle dot com
--- Comment #5 from Jose E. Marchesi <jose.marchesi at oracle dot com> ---
Yes that would require changing the kernel ABI. Also, there is the kernel
verifier to deal with: stack accesses are tracked at load-time and they should
be done using certain registers and following certain rules.
For the time being, --disabling-gcov when building for BPF seems like a
reasonable thing to do. Will write and send a patch in that effect.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104656] [12 Regression] trunk 20220222 ftbfs for bpf
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
` (5 preceding siblings ...)
2022-02-23 13:15 ` jose.marchesi at oracle dot com
@ 2022-02-24 15:44 ` cvs-commit at gcc dot gnu.org
2022-03-09 13:02 ` rguenth at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-02-24 15:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jose E. Marchesi <jemarch@gcc.gnu.org>:
https://gcc.gnu.org/g:39be73d07bb667fd5d313a3398f5399e091f2c0c
commit r12-7373-g39be73d07bb667fd5d313a3398f5399e091f2c0c
Author: Jose E. Marchesi <jose.marchesi@oracle.com>
Date: Wed Feb 23 20:48:30 2022 +0100
bpf: do not --enable-gcov for bpf-*-* targets
This patch changes the build machinery in order to disable the build
of GCOV (both compiler and libgcc) in bpf-*-* targets. The reason for
this change is that BPF is (currently) too restricted in order to
support the coverage instrumentalization.
Tested in bpf-unknown-none and x86_64-linux-gnu targets.
2022-02-23 Jose E. Marchesi <jose.marchesi@oracle.com>
gcc/ChangeLog
PR target/104656
* configure.ac: --disable-gcov if targetting bpf-*.
* configure: Regenerate.
libgcc/ChangeLog
PR target/104656
* configure.ac: --disable-gcov if targetting bpf-*.
* configure: Regenerate.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/104656] [12 Regression] trunk 20220222 ftbfs for bpf
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
` (6 preceding siblings ...)
2022-02-24 15:44 ` cvs-commit at gcc dot gnu.org
@ 2022-03-09 13:02 ` rguenth at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-03-09 13:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104656
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-03-09 13:02 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 8:55 [Bug target/104656] New: [12 Regression] trunk 20220222 ftbfs for bpf doko at debian dot org
2022-02-23 10:38 ` [Bug gcov-profile/104656] " pinskia at gcc dot gnu.org
2022-02-23 10:41 ` [Bug target/104656] " rguenth at gcc dot gnu.org
2022-02-23 11:04 ` doko at debian dot org
2022-02-23 11:09 ` jakub at gcc dot gnu.org
2022-02-23 11:16 ` pinskia at gcc dot gnu.org
2022-02-23 13:15 ` jose.marchesi at oracle dot com
2022-02-24 15:44 ` cvs-commit at gcc dot gnu.org
2022-03-09 13:02 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).