From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id E35703858037; Thu, 3 Mar 2022 14:20:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E35703858037 From: "dmalcolm at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug analyzer/104680] identical inner condition not detected Date: Thu, 03 Mar 2022 14:20:43 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: analyzer X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: diagnostic X-Bugzilla-Severity: enhancement X-Bugzilla-Who: dmalcolm at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 14:20:44 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D104680 --- Comment #7 from David Malcolm --- > trunk.git/zlib/contrib/minizip/zip.c:1212:26: warning: Identical inner 'i= f' condition is always true. [identicalInnerCondition] In zipOpenNewFileInZip4_64: 1206 =E2=94=82 #ifdef HAVE_BZIP2 1207 =E2=94=82 if ((err=3D=3DZIP_OK) && (zi->ci.method =3D=3D Z_DEFLA= TED || zi->ci.method =3D=3D Z_BZIP2ED) && (!zi->ci.raw)) 1208 =E2=94=82 #else 1209 =E2=94=82 if ((err=3D=3DZIP_OK) && (zi->ci.method =3D=3D Z_DEFLA= TED) && (!zi->ci.raw)) 1210 =E2=94=82 #endif 1211 =E2=94=82 { 1212 =E2=94=82 if(zi->ci.method =3D=3D Z_DEFLATED) 1213 =E2=94=82 { Arguably a false positive: it's going to be a repeated test if the preproce= ssor uses line 1209, but not if it uses line 1207.=