[Bug target/104724] New: gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL

[Bug target/104724] New: gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104724

            Bug ID: 104724
           Summary: gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: crazylht at gmail dot com
  Target Milestone: ---
            Target: i?86-pc-solaris2.11, x86_64-pc-solaris2.11

A couple of tests FAIL on Solaris/x86 since their introduction:

+FAIL: gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c (test for excess errors)
+UNRESOLVED: gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c compilation failed to
produce executable

+FAIL: gcc.target/i386/avx512fp16-vcvtusi2sh-1b.c (test for excess errors)
+UNRESOLVED: gcc.target/i386/avx512fp16-vcvtusi2sh-1b.c compilation failed to
produce executable

  32 and 64-bit x86

+FAIL: gcc.target/i386/avx512fp16-vcvtsi2sh64-1b.c (test for excess errors)
+UNRESOLVED: gcc.target/i386/avx512fp16-vcvtsi2sh64-1b.c compilation failed to
produce executable
+FAIL: gcc.target/i386/avx512fp16-vcvtusi2sh-1b.c (test for excess errors)
+UNRESOLVED: gcc.target/i386/avx512fp16-vcvtusi2sh-1b.c compilation failed to
produce executable
+FAIL: gcc.target/i386/avx512fp16-vcvtusi2sh64-1b.c (test for excess errors)
+UNRESOLVED: gcc.target/i386/avx512fp16-vcvtusi2sh64-1b.c compilation failed to
produce executable

  64-bit x86

The failure mode is always the same:

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c:12:33:
error: unknown type name '__int64_t'; did you mean 'uint64_t'?
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c:33:3:
warning: implicit declaration of function 'emulate_vcvtsi2sh'
[-Wimplicit-function-declaration]

I believe the tests should just avoid the non-standard __int64_t type and
instead
include <stdint.h> and use int64_t like many other tests.do.

[Bug target/104724] gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104724

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug target/104724] gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104724

--- Comment #1 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
Created attachment 52531
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52531&action=edit
A patch

Hi Rainer, can you try this on your solaris system? We don't have such platform
to confirm it works.

I'll install it if it passes, or you can directly push it as an obvious fix.

[Bug target/104724] gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104724

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
[...]
> Hi Rainer, can you try this on your solaris system? We don't have such platform
> to confirm it works.
>
> I'll install it if it passes, or you can directly push it as an obvious fix.

Sure: the patch worked for me just fine.  Can you please commit it?  Thanks.

[Bug target/104724] gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104724

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hongyu Wang <hongyuw@gcc.gnu.org>:

https://gcc.gnu.org/g:70fe5736c2935926b060fd3ce164838f9c4aadea

commit r12-7442-g70fe5736c2935926b060fd3ce164838f9c4aadea
Author: Hongyu Wang <hongyu.wang@intel.com>
Date:   Tue Mar 1 17:49:52 2022 +0800

    AVX512FP16: Fix vcvt[u]si2sh runtime tests for Solaris

    Use standard C type instead of __int64_t which doesn't work on Solaris.

    gcc/testsuite/ChangeLog:

            PR target/104724
            * gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c: Use long long
            instead of __int64_t.
            * gcc.target/i386/avx512fp16-vcvtsi2sh64-1b.c: Ditto.
            * gcc.target/i386/avx512fp16-vcvtusi2sh-1b.c: Ditto.
            * gcc.target/i386/avx512fp16-vcvtusi2sh64-1b.c: Ditto.

[Bug target/104724] gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104724

--- Comment #4 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
Fixed for GCC 12.

[Bug testsuite/104724] gcc.target/i386/avx512fp16-vcvtsi2sh-1b.c etc. FAIL

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104724

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
          Component|target                      |testsuite
           Keywords|                            |testsuite-fail

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.