[Bug target/104726] New: gcc.target/i386/pr104551.c FAILs

[Bug target/104726] New: gcc.target/i386/pr104551.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

            Bug ID: 104726
           Summary: gcc.target/i386/pr104551.c FAILs
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: crazylht at gmail dot com
  Target Milestone: ---
            Target: i?86-pc-solaris2.11, x86_64-pc-solaris2.11

The gcc.target/i386/pr104551.c test FAILs on Solaris/x86 (32 and 64-bit) since
its introduction:

+FAIL: gcc.target/i386/pr104551.c execution test

Thread 2 received signal SIGILL, Illegal instruction.
[Switching to Thread 1 (LWP 1)]
0x080510ff in main ()
(gdb) bt
#0  0x080510ff in main ()
(gdb) x/i $pc
=> 0x80510ff <main+15>: vmovd  %eax,%xmm0

The machine in question indeed lacks AVX2 support.  I guess the test needs to
use
avx2-check.h to handle this.

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

--- Comment #1 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
Created attachment 52532
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52532&action=edit
A patch

Hi Rainer, can you try this on your solaris system? We don't have such platform
to confirm it works.

I'll install it if it passes, or you can directly push it as an obvious fix.

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Removing the eff. target avx2 is wrong, that makes sure the assembler can
support that isa, which you still need

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Also, the builtin at the start of main compiled with -mavx2 is risky, there
could be avx2 insns e.g. in the prologue. avx2-check.h is the usual way

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

Hongyu Wang <wwwhhhyyy333 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52532|0                           |1
        is obsolete|                            |

--- Comment #4 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
Created attachment 52535
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52535&action=edit
Updated patch



(In reply to Jakub Jelinek from comment #3)
> Also, the builtin at the start of main compiled with -mavx2 is risky, there
> could be avx2 insns e.g. in the prologue. avx2-check.h is the usual way

Thanks for pointing it out, updated accordingly.

Hi Rainer, sorry for previous mistake, can you try the updated one?

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #4 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
[...]
> Hi Rainer, sorry for previous mistake, can you try the updated one?

Of course: just did and it works fine.  Thanks.

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hongyu Wang <hongyuw@gcc.gnu.org>:

https://gcc.gnu.org/g:2f1fa70db51f5356e308e757210d0e521a32e1b7

commit r12-7443-g2f1fa70db51f5356e308e757210d0e521a32e1b7
Author: Hongyu Wang <hongyu.wang@intel.com>
Date:   Tue Mar 1 19:59:03 2022 +0800

    i386: Fix pr104551 testcase for solaris

    Use avx2-check mechanism to avoid illegal instrucion on non-avx2 target.

    gcc/testsuite/ChangeLog:

            PR target/104726
            * gcc.target/i386/pr104551.c: Use avx2-check.h.

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

--- Comment #7 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
Fixed for GCC 12.

[Bug target/104726] gcc.target/i386/pr104551.c FAILs

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.0                        |12.2

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 12.1 is being released, retargeting bugs to GCC 12.2.

[Bug testsuite/104726] gcc.target/i386/pr104551.c FAILs

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104726

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|target                      |testsuite
   Target Milestone|12.3                        |12.0
         Resolution|---                         |FIXED

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.