[Bug c++/104734] New: -isystem hides -Woverloaded-virtual warning

[Bug c++/104734] New: -isystem hides -Woverloaded-virtual warning

[albert.astals.cid at kdab dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104734

            Bug ID: 104734
           Summary: -isystem hides -Woverloaded-virtual warning
           Product: gcc
           Version: 11.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: albert.astals.cid at kdab dot com
  Target Milestone: ---

I have a class that inherits from a class that is a system header.

The system header class has

virtual bool edit(const QModelIndex &index, EditTrigger trigger, QEvent
*event);

my class has

bool edit(const QModelIndex &index, int editDay);

when compiling with -I to add include paths i get

In file included from /usr/include/qt/QtWidgets/qtreeview.h:44,
                 from /usr/include/qt/QtWidgets/QTreeView:1,
                 from
/home/tsdgeos/kdab/private/KDABViewer/Widgets/TimelineWidget.h:4,
                 from
/home/tsdgeos/kdab/private/KDABViewer/Widgets/TimelineWidget.cpp:1:
/usr/include/qt/QtWidgets/qabstractitemview.h:297:18: warning: ‘virtual bool
QAbstractItemView::edit(const QModelIndex&, QAbstractItemView::EditTrigger,
QEvent*)’ was hidden [-Woverloaded-virtual]
  297 |     virtual bool edit(const QModelIndex &index, EditTrigger trigger,
QEvent *event);
      |                  ^~~~
In file included from
/home/tsdgeos/kdab/private/KDABViewer/Widgets/TimelineWidget.cpp:1:
/home/tsdgeos/kdab/private/KDABViewer/Widgets/TimelineWidget.h:66:10: note:  
by ‘bool TimelineWidget::edit(const QModelIndex&, int)’
   66 |     bool edit(const QModelIndex &index, int editDay);
      |          ^~~~

but if instead of -I i use -isystem the warning is gone.

This feels wrong since the warning is about my code, not about the system
include code.

[Bug c++/104734] -isystem hides -Woverloaded-virtual warning

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104734

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic
   Last reconfirmed|                            |2022-03-03
             Status|UNCONFIRMED                 |WAITING
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Can you attach the preprocesed source for both cases?
You can get it via -save-temps option added.

[Bug c++/104734] -isystem hides -Woverloaded-virtual warning

[albert.astals.cid at kdab dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104734

--- Comment #2 from Albert Astals Cid <albert.astals.cid at kdab dot com> ---
Created attachment 52589
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52589&action=edit
preprocessed source with -isystem

[Bug c++/104734] -isystem hides -Woverloaded-virtual warning

[albert.astals.cid at kdab dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104734

--- Comment #3 from Albert Astals Cid <albert.astals.cid at kdab dot com> ---
Created attachment 52590
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52590&action=edit
preprocessed source with -I

[Bug c++/104734] -isystem hides -Woverloaded-virtual warning

[albert.astals.cid at kdab dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104734

--- Comment #4 from Albert Astals Cid <albert.astals.cid at kdab dot com> ---
Added both the pre-processed source with both -isystem and -I

They seem mostly the same except some ¿annotations/comments?

Had to compress them with xz since otherwise they were too big to attach, hope
that's OK.

[Bug c++/104734] -isystem hides -Woverloaded-virtual warning

[albert.astals.cid at kdab dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104734

--- Comment #5 from Albert Astals Cid <albert.astals.cid at kdab dot com> ---
Ping

I provided the requested information, can someone move this out of WAITING
state?

[Bug c++/104734] -isystem hides -Woverloaded-virtual warning

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104734

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |UNCONFIRMED
     Ever confirmed|1                           |0